sfu-ws prometheus seems to have issue with - in key names. about example-webrtc-applications HOT 3 CLOSED

when building sfu-ws as docker container using this dockerfile.

FROM golang:latest ENV GO111MODULE=on WORKDIR /go/src/ RUN git clone https://github.com/pion/webrtc.git WORKDIR /go/src/webrtc RUN go mod download RUN git clone https://github.com/pion/example-webrtc-applications.git WORKDIR /go/src/webrtc/example-webrtc-applications/sfu-ws RUN go get RUN go build RUN ./sfu-ws

I get a panic when application starts at main.go line 39 due to "-" in application name in this part
if err := prometheus.Register(prommod.NewCollector("sfu-ws")); err != nil { panic(err) }

replacing it with
if err := prometheus.Register(prommod.NewCollector("sfu_ws")); err != nil { panic(err) }
seems to ease prometheus.

from example-webrtc-applications.

Hey @Ola-Palm

Thanks for debugging this! If you are interested I would love a PR to fix this :) will merge right away.

Make sure to add yourself to the README, and write a subject + body commit message. Our .travis.yml contains everything that is run in CI.

from example-webrtc-applications.

My bad. I will fix it today

from example-webrtc-applications.