Giter VIP home page Giter VIP logo

Comments (3)

Sean-Der avatar Sean-Der commented on September 25, 2024 1

If anyone is interested in this I think it would be a great idea to export the lexer. Users could override specific steps in the state machine if needed.

I haven't seen/heard any demand for this in the 3 years since this issues has opened. I am going to close as 'not planned'. If someone has an interest to take this on I would love to help them though!

from sdp.

Sean-Der avatar Sean-Der commented on September 25, 2024

I am worried if we make a permissive path it may result in bad SDPs getting through the non-permissive path.

What do you think of maybe providing a tokenizer so that users can go line by line themselves. That way we don't have two Unmarshal functions. Users that want to take the risk can go do it, but not complicate the API maybe?

from sdp.

babolivier avatar babolivier commented on September 25, 2024

I am worried if we make a permissive path it may result in bad SDPs getting through the non-permissive path.

From my point of view, it really depends on what you want to do when parsing SDP. For instance, what I'm working with right now only cares about getting a Go structure that it can manipulate (e.g. append candidates retrieved separately) and then marshal into a string it can pass on; in which case the extra validation is nice to have (as long as it doesn't get in the way, e.g. with bandwidth types) but not what I'm primarily looking for.

To be perfectly honest I've suggested to have a second Unmarshal function because that's the only idea I had (and didn't have a lot of time to write this issue) but other solutions might be better as long as they can serve the same goal.

from sdp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.