Comments (3)
If anyone is interested in this I think it would be a great idea to export the lexer
. Users could override specific steps in the state machine if needed.
I haven't seen/heard any demand for this in the 3 years since this issues has opened. I am going to close as 'not planned'. If someone has an interest to take this on I would love to help them though!
from sdp.
I am worried if we make a permissive path it may result in bad SDPs getting through the non-permissive path.
What do you think of maybe providing a tokenizer so that users can go line by line themselves. That way we don't have two Unmarshal functions. Users that want to take the risk can go do it, but not complicate the API maybe?
from sdp.
I am worried if we make a permissive path it may result in bad SDPs getting through the non-permissive path.
From my point of view, it really depends on what you want to do when parsing SDP. For instance, what I'm working with right now only cares about getting a Go structure that it can manipulate (e.g. append candidates retrieved separately) and then marshal into a string it can pass on; in which case the extra validation is nice to have (as long as it doesn't get in the way, e.g. with bandwidth types) but not what I'm primarily looking for.
To be perfectly honest I've suggested to have a second Unmarshal
function because that's the only idea I had (and didn't have a lot of time to write this issue) but other solutions might be better as long as they can serve the same goal.
from sdp.
Related Issues (20)
- Dependency Dashboard
- Add MSRP support HOT 1
- SDP Unmarshal (lexer) syntax errors are unwieldy and difficult to work with HOT 1
- Port old fuzzing code to Go's new fuzzing tools HOT 4
- Migrate entire library to a version with attribute broken down HOT 1
- payload type not found error HOT 2
- SDP session part orders HOT 1
- Please add a new release tag HOT 1
- Parser can not read attributes with wildcards HOT 2
- sdp support transport-cc HOT 1
- Any interest in a direct RFC ABNF generated Go parser??? HOT 3
- sdp file parsing failed HOT 7
- Support non-canonical SDP for RTSP HOT 2
- Validate UnicastAddress properly HOT 1
- NewJSEPMediaDescription doesn't process codecPrefs HOT 2
- define the RTP port range HOT 4
- Add GetFingerprint() to SessionDescription HOT 5
- Action Required: Fix Renovate Configuration
- Support more values for the bandwidth types when parsing `b=` attributes HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sdp.