Giter VIP home page Giter VIP logo

Comments (3)

Sean-Der avatar Sean-Der commented on June 13, 2024

Thanks for the ticket @daweifeng!

We need to get pion/sctp#284 merged. I will review

If you are interested @daweifeng I would appreciate your help reviewing the PR :)

from webrtc.

daweifeng avatar daweifeng commented on June 13, 2024

Thank you! The PR fixes my issue. I will take a look at the PR as well!

from webrtc.

paullouisageneau avatar paullouisageneau commented on June 13, 2024

@Sean-Der This has been marked as completed but the corresponding PR is not merged. The bug is still present and is breaking compatibility between pion and libdatachannel 0.20.

As discussed in paullouisageneau/libdatachannel#1030 (comment), the actual issue is not that parameter type 0x8001 is not handled (which is implemented by pion/sctp#284), it's that unmarshalling in pion seemingly fails on all unhandled parameters.

An SCTP endpoint does not need to support Zero Checksum Acceptable extension to connect with an endpoint that does. According to RFC 9260 that the endpoint behavior must depend on the highest-order two bits of the parameter type. Here it's 10, so the endpoint must skip the parameter and continue to process other parameters if it doesn't know it. Failing on unknown parameters breaks if peers attempt to negotiate SCTP extensions.

from webrtc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.