feature request: table prefix about cockpit-sql-driver HOT 8 CLOSED

Was there a wp_users table in your database before running second query?

As for creating tables on the fly

I've decided to create collection tables on the fly, because it's cleaner and at first seemed cheaper than in every method (find/ insert/ delete/ count).

My assumption was that if developer decides to operate on collection/ table, he/ she is sure it exists.

Probably this could be refactored with a cached table exists check on every read type operation and create table on write type,

from cockpit-sql-driver.

Was there a wp_users table in your database before running second query?

Yes. I tested it with a WordPress installation in the same database. I know, it's better to use different hosts and databases per app, but people do such things. Especially in the WordPress world with the cheapest web hoster possible, where a second database costs extra money.

Well, ... and I'm working on a Cockpit implementation as a WordPress plugin...

My assumption was that if developer decides to operate on collection/ table, he/ she is sure it exists.

If we ignore typos and tests with wrong methods while getting started with Cockpit, there is still the possibility, that a different addon author uses a table name, that exists already in my database. A table prefix would eliminate these conflicts.

Probably this could be refactored with a cached table exists check on every read type operation and create table on write type,

That sounds nice, but I think, it behaves like the SQLite driver right now. If I remember correctly, that one creates empty tables on read requests on the fly, too.

from cockpit-sql-driver.

I'll prepare table prefix feature and let's leave table checks for other time as it's separate issue

from cockpit-sql-driver.

Could you test feature in #7?

from cockpit-sql-driver.

It seems, like nothing has changed. I guess, you have to add the prefix to the query builder, too.

from cockpit-sql-driver.

Sorry, my fault. I renamed the old SqlDriver module instead of deleting it and copied the fork, so it was loaded before the replacemant fired. Stupid mistake :D

So it seems to work with the prefix.
After creating a test entry in a test collection, I have these new databases:

cp_cockpit/accounts
cp_cockpit/options
cp_cockpit/revisions
cp_collections/test

And this one created a new table cp_test:

$this->on('cockpit.bootstrap', function() {
    $test = $this->storage->getKey('test', 'test', []);
    var_dump($test); // array(0) { } 
});

Thank you very much for that fast fix.

from cockpit-sql-driver.

After some more tests, it looks very promising. I added an asset and a singleton via Cockpit UI, I sent a message with a contact form from the WordPress frontend and it was successfully stored. Now my database looks much cleaner than before.

from cockpit-sql-driver.

Let's continue thread on on #7

from cockpit-sql-driver.