Using wrong device id will return integer 0 instead of string from serial_number and device_name attributes about flexit_bacnet HOT 5 CLOSED

@Kazhuu would returning an empty string on that occasion solve it?

from flexit_bacnet.

I think that will but is this even supposed to be a valid connection with wrong device id? I'm not that familiar with BACnet protocol to know this. If so, could this already be checked earlier when the connection is made for the first time and some error thrown or something similar? If it's supposed to be valid connection, then this is also fine. Maybe this should be mentioned in the README as well?

from flexit_bacnet.

I guess this solution also solves the issue @piotrbulinski. With this change I only need to compare to the empty string instead of integer.

from flexit_bacnet.

@Kazhuu I think that's the best for now. I've released version 2.1.1 with that fix.

from flexit_bacnet.

Thanks!

from flexit_bacnet.