Giter VIP home page Giter VIP logo

Comments (4)

flq avatar flq commented on June 15, 2024

Um, getType() is exposed?

The way to use it is usually case getType(someAction):

from typesafe-actions.

geakstr avatar geakstr commented on June 15, 2024

@flq I'm talking about

switch (action.type) {
  case someTypesafeAction.getType(): {
    // action typed correctly here
    break;
  }
}

I'm not sure this example works in the current package version

from typesafe-actions.

piotrwitek avatar piotrwitek commented on June 15, 2024

It's an implementation detail and I don't recommend using this.
The problem with it is that if you add some extra property to the static type of an action creator, then redux type constraints will be throwing errors at you, this is some limitation I run into in the past.

I could make it optional, but you will need to assert first to use it:

switch (action.type) {
  case someTypesafeAction.getType!(): {
    // action typed correctly here
    break;
  }
}

I still consider this as a bad practice and I cannot recommend this approach.

from typesafe-actions.

geakstr avatar geakstr commented on June 15, 2024

Ok, got it, thanks

from typesafe-actions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.