{Object}.save not working about client-nodejs HOT 6 CLOSED

As a follow up. I was able to reproduce the issue finally, and the delete was unrelated to my problem but a http error of 4xx group as this issue relates to.

We basically have a situation where we do a object.save(handler) call when nothing was changed in the object. In this case the client is doing a put with an empty object {} as no value has changed, and the server response with 400.

The main issue is, therefore, that save, merge and duplicate do not propagate the error to the handler, but instead try to access data. All these functions generate the same mentioned error in case the server response with anything else besides 200 containing an empty body.

This should be easy to fix.

from client-nodejs.

I have the same issue with the following:

console.log("initial: ", person["First Name"]); // output: undefined
person.set("First Name", firstName);
person.set("Last Name", lastName);
console.log("saved: ", person["First Name"]); // output: Bradley
person.save(function(err) { console.log("error", err); });

result is:

..../node_modules/pipedrive/lib/wrapCollectionItems.js:12
			var itemId = item.id || false;
			                  ^

TypeError: Cannot read property 'id' of null
    at doWrap (..../node_modules/pipedrive/lib/wrapCollectionItems.js:12:22)
    at ..../node_modules/pipedrive/lib/wrapCollectionItems.js:37:5

from client-nodejs.

@super-cache-money Did you get "Got deal" in console? I think you don't have deal with id 123, so you can't save it. Tried your code, works ok to me

from client-nodejs.

Hey, this issue occurs for me when doing pipedrive.Deals.get on a deleted deal. The item passed into wrapCollectionItems.js:12:21 is null, and hence has no item.id.

I would prefer an empty collection for this case, as it allows us to handle the not found case.

Can you fix this?

from client-nodejs.

from client-nodejs.

Still seeing the problem @JohannesHome mentions. When running within Node, hitting this kind of error in any call causes Node to crash, with no chance to intercept in a try/catch or callback.

We can't use this library because of this problem.

from client-nodejs.