Comments (2)
In short: I'm negative to implement this as a built-in option. TST's special behavior on a collapsed tree + shift-click is based on the policy to keep consistency.
Shift-click on a tab is an action to highlight tabs between the clicked tab and the previously clicked or the active tab.
Assume that there are some tabs:
- [A]
- [B]
- [C] (Active)
- [C-1]
- [C-2]
On this case,
- When the tree "C" is expanded, Shift-click on "A" will highlight the clicked "A", the active "C" and all their between tabs, so it will highlight only "A", "B" and "C". This is natural from their visibility.
- However, when the tree "C" is collapsed, Shift-click on "A" will highlight "A", "B", "C", "C-1" and "C-2". This is because to prevent "C-1" and "C-2" are left there after you move highlighted tabs to another place.
- Shift-click on "B" will highlight "B", "C", "C-1" and "C-2", from same reason.
- So, how we should treat Shift-click on "C"? Currently it is treated as "the clicked C, the active C, all tabs between them, and C's collapsed children". Why?
TST's this kind behaviors refer the one on other UIs in Firefox and other major applications. The basic strategy of Shift-click on this case refers item selection on Firefox's "Browsing Library" and Windows Explorer.
- On "Browsing Library", a list may contain both bookmark items and bookmark folders. When you drag multiselected items including bookmark items and folders and drop them to another folder, all dragged items and folders are moved under the drop target, and of course descendants of moved folders are still descendants of the moved folders - they won't be left under the original folder dragged folders were in. So, I think the current behavior - descendants are also moved if a moved tab has collapsed descendants - is similar the one of the Browsing Library and reasonable.
- Another case, the "list view" of macOS's Finder is also similar to these UI. On Finder, shift-click on a folder just highlights the clicked folder (and items between the active item) but children of the clicked folder won't be highlighted whether the folder is expanded or collapsed on the view. This selection behavior is similar to TST's one about the expanded tree case.
- Drag-and-drop of them will move them and their descendants also. This is not similar to TST does.
- But setting color label from the context menu just applies chosen label for highlighted items and folders - descendants are kept color label free. This is similar to TST does.
We need to remind that TST's (Frefox's) tabs are different from items and folders on these cases. TST's tab behaves like both folder and item. It needs to be moved individually like told at #3538, so simulating the behavior of macOS's Finder completely (move descendants together even if only the parent is highlighted) looks not suitable.
However any helper addon providing the behavior (shift-click on an expanded tree parent to select all its descendants) is always welcome. I'll add it to the list of known helper addons if you publish it.
from treestyletab.
Thanks for the explanation, I'll look into developing a solution.
EDIT A personal reminder to acknowledge the potential importance/utilisation of unfocused TST sidebar prior to Shift click to remediate issues with previous focused/selected tab.
from treestyletab.
Related Issues (20)
- [Bug] Drag and drop parent-child / subtree broken on 4.0.11 HOT 2
- [Bug] Recent update shows booksmark manager, not tabs HOT 2
- [Bug] Move to New Window button causes all tab bars to reload twice after the new window opens HOT 10
- "Scroll Lock" does not work (How to disable automatic scrolling of tab column when manually closing second-to-last tab?) HOT 4
- [Bug] photon sidebar backround is too light on linux HOT 6
- New version 4.0.12 changed some of the styling HOT 9
- "Open new blank tab as" setting is ignored HOT 4
- new tab from non-existing tab HOT 1
- [Bug] "Undefined" entries at bottom of sidebar HOT 2
- [Bug] Switches tabs with certain sequences of keypresses/mouse clicks
- [Bug] TST Tab Search extension no longer works correctly with TST HOT 6
- [Bug] Drag and droping outside of sidebar not working when maximised HOT 1
- [Enhancement] toggle expand/collapse function HOT 2
- [Enhancement] Drag parent onto child HOT 1
- TST tab list blank when moving firefox window to different monitor (Error location found) HOT 2
- Tab counter is broken in latest update HOT 3
- [Enhancement] Drag N' Drop, maintain folded state HOT 3
- [Enhancement] Auto show and hide TST when needed HOT 2
- [Bug] Unable to zoom sidebar on MacOS HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from treestyletab.