Giter VIP home page Giter VIP logo

Comments (2)

piroor avatar piroor commented on May 9, 2024

Thanks. This commit solves the conflict: 93ab502

Because TST requires a custom binding for the tab toolbar, TST includes some CSS rules to override Firefox's CSS itself ( http://mxr.mozilla.org/mozilla-central/source/browser/themes/winstripe/browser/browser-aero.css#202 ) The Firefox's rules has ":last-child" pseudo class, so I also added it to my rules. However, Request Policy dynamically inserts a menupopup into the toolbox as the last child. Then TST's custom CSS rules are momentarily-lost. This is the reason of this conflict.

The commit re-defines TST's CSS rules with ":not(:last-child)" pseudo class. In the next release, TST always apply its custom rules even if Request Policy insert a menupopup into the toolbox.

By the way, I think the toolbox is not a good insertion point for menupopup. I think any dynamic menupopup should be inserted into the popupset#mainPopupSet...

from treestyletab.

 avatar commented on May 9, 2024

Thank you for the very fast response and fix. I've also opened a RequestPolicy ticket for your suggestion of where the RequestPolicy menupopup should be inserted (https://www.requestpolicy.com/dev/ticket/188).

from treestyletab.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.