"Create New Group from Tabs" Breaks Some Functionality By Recent Update Version 1.4 Compared To Version 1.3 about tst-more-tree-commands HOT 4 CLOSED

Sorry for long response.
I am the author of changes for "Create group" functionality, which came with 1.4 update. Sorry to hear it caused problems for you.

As for 1st problem, I can totally see why it happens – with new condition for enabling the context menu entry I haven't thought of use cases when you have group inside another group. Could you please download my fork and test, if this problem still occurs there?

As for the second problem, I'm not really sure why it may happen – the logic when user has more than one tab selected remained untouched in 1.4. Are you sure this behavior was different in previous version?

from tst-more-tree-commands.

Yes I extracted the files from your fork and combined them with the extracted most recent copy of tst-more-commands by piroor & together they did work to fix both issues, also the second issue makes more sense if I just was to say it caused any indented tabs of higher parts of tree where groups were created all tabs selected before using the group context menu item to be flattened to the outmost part of the group keeping the order of all tabs but not the indent that made it possible to discern which tabs were connected to other tabs. Take these 5 tabs right here in image 1 the first 4 are connected one indent in each time with the last being on the same level as the 2nd

when using the group command with no other modifications besides the group command on all 5 tabs results in image 2

This behavior is unlike v1.3 I have a copy if you'd like me to upload it.

from tst-more-tree-commands.

I just tested it with recent changes in my fork, and it seems both issues are resolved. When I create a new group, the indentation is kept. I will submit pull request now.

from tst-more-tree-commands.

I close this with the merged PR. Thanks!

from tst-more-tree-commands.