print_topics() should work with logging disabled about gensim HOT 6 CLOSED

print_topics used to print the topics (hence the name, which is misleading now), but users complained that gensim is a library and as such shouldn't print anything. And I agree.

What I can do, is return a string instead of None. That way you'll be able to do print print_topics() and see output like in the log. It will make calling print_topics() from shell ugly though, so maybe I'll make that conditional (a parameter flag or smt).

Yeah now that I think of it, I'll rename print_topics to show_topics, and make print_topics an alias with that flag turned on.

from gensim.

Went ahead and took a shot at something like the change described in 5b10b6d85e6d3e366a06867f5ec321c69fe3db20. Not sure whether it's exactly what @piskvorky had in mind (e.g. I also changed print_topic) but it does the trick for me!

from gensim.

The other option that would be appropriate for a library is to have
that function return a list of strings, one for each topic.

On Thu, Aug 25, 2011 at 5:16 PM, strongh
[email protected]
wrote:

Went ahead and took a shot at something like the change described in 5b10b6d85e6d3e366a06867f5ec321c69fe3db20. Not sure whether it's exactly what @piskvorky had in mind (e.g. I also changed print_topic) but it does the trick for me!

Reply to this email directly or view it on GitHub:
#47 (comment)

RRR

from gensim.

@DataJunkie my version of show_topics returns a list of strings per topic when the keyword argument formatted is True. The strings are formatted as in the log files. Is this what you were thinking?

from gensim.

@strongh great, that is indeed what I had in mind :) I'll have a look & test & merge when I get back home (end of month). Thanks!

from gensim.

Fixed in #50 . Let me know if there are any further issues.

from gensim.