Library shouldn't write to std::cout nor std::cerr. about pistache HOT 5 CLOSED

Yes, I am also not a big fan of the std::function solution. I would rather provide a more elaborate logging system that you could control outside of the library to enable debug/info/trace debugging or not.

Anyway, I just removed it: 37807ce

from pistache.

Hello,

Do you think the library should not output anything at all or should it provide options to shut if off ?

from pistache.

The library should provide the message though an "API" instead.
Call a std::function that user is free to define ;)
What would be nice would be a std::function<void(levels,std::string)> with enum levels {ok,info,notice,warning,error,critical}; for all messages.
And a distinct std::function<void(uint,std::string)> to build an acces log (http code and url).

but that's just my opinion :P

from pistache.

Inside the program you already know whether the listening was successfully established or not. I think there shouldn't be a message at all. If I wanted to print one, the program using your library should do it.

Regarding the message API sebt3 suggested: I am not sure this is needed here.

from pistache.

Awesome, thanks!

from pistache.