Giter VIP home page Giter VIP logo

Comments (4)

Barry-Fisher avatar Barry-Fisher commented on June 2, 2024

Hi @dev7ch

I've been adding end-to-end tests to this package and I was able to duplicate the "Cannot read property of 'includes' of undefined" bug. This is now fixed in the latest version 1.1.1 on npm.

As for the class issue, let's leave this issue open. There's an more optimal way, I'm sure, to pass through any attributes not explicitly needed by the <nuxt-img> component. Please leave this with me.

As for:

Finally i still have to generate image locally and commit them

Again, please try again with v1.1.1 as you may find this is now fixed.

Thanks,

Barry

from nuxt-image-loader-module.

dev7ch avatar dev7ch commented on June 2, 2024

Hey @barryrld thank you for the detailed reply! sorry for mixing issues.

regarding :class perfect.

i ll updated within the next 2 days as you mentioned and report it here.

from nuxt-image-loader-module.

Barry-Fisher avatar Barry-Fisher commented on June 2, 2024

Hi @dev7ch

The passing of class and style attributes in the <nuxt-img> component is now fixed in version 1.1.2 for both a static string or a data binding with v-bind.

I'd appreciate your feedback to confirm this is fixed in your 'real world' project when you get a chance. The commit automatically closed this issue, so please feel free to open if you're still having an issue with this.

Thanks,

Barry

from nuxt-image-loader-module.

dev7ch avatar dev7ch commented on June 2, 2024

@barryrld 👍 can confirm both works in release v1.1.2.

from nuxt-image-loader-module.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.