Giter VIP home page Giter VIP logo

Comments (14)

themoonrat avatar themoonrat commented on May 19, 2024

Have you done an npm i since the last release? As it added a build step in

from particle-emitter.

marekventur avatar marekventur commented on May 19, 2024

@themoonrat: yes, that how I got the new version in the first place. Our jenkins does a fresh build every time and gets the same error.

from particle-emitter.

themoonrat avatar themoonrat commented on May 19, 2024

ah ok. Haven't actually done a new build on 2.1.0 yet, but adding pixify for the build stage is what would have caused it

from particle-emitter.

andrewstart avatar andrewstart commented on May 19, 2024

I redid my npm install, and didn't have a problem building or running the examples afterwards. Is the error you are getting during npm run build or when trying to use the library after building?

from particle-emitter.

marekventur avatar marekventur commented on May 19, 2024

npm install works without a problem, it's when we run browserify that an error gets thrown:

00:07:10.535 [14:34:10] Starting 'browserify'...
00:07:16.695 events.js:141
00:07:16.695       throw er; // Unhandled 'error' event
00:07:16.695       ^
00:07:16.695 
00:07:16.695 Error: Cannot find module './ParticleUtils' from '/var/lib/jenkins/jobs/game-master/workspace/node_modules/pixi-particles/dist'
00:07:16.695     at /var/lib/jenkins/jobs/game-master/workspace/node_modules/browserify/node_modules/browser-resolve/node_modules/resolve/lib/async.js:55:21
00:07:16.695     at load (/var/lib/jenkins/jobs/game-master/workspace/node_modules/browserify/node_modules/browser-resolve/node_modules/resolve/lib/async.js:69:43)
00:07:16.695     at onex (/var/lib/jenkins/jobs/game-master/workspace/node_modules/browserify/node_modules/browser-resolve/node_modules/resolve/lib/async.js:92:31)
00:07:16.695     at /var/lib/jenkins/jobs/game-master/workspace/node_modules/browserify/node_modules/browser-resolve/node_modules/resolve/lib/async.js:22:47
00:07:16.695     at FSReqWrap.oncomplete (fs.js:82:15)

from particle-emitter.

marekventur avatar marekventur commented on May 19, 2024

I can try to reduce it down to a minimal example, but I was hoping the problem would be obvious from the description :(

from particle-emitter.

andrewstart avatar andrewstart commented on May 19, 2024

Ah, you are trying to browserify pixi-particles into your code? I haven't used browserify too much - are there any known problems with browserifying a browserified library?

from particle-emitter.

marekventur avatar marekventur commented on May 19, 2024

generally not, at least none I'm aware of.

from particle-emitter.

andrewstart avatar andrewstart commented on May 19, 2024

It is indeed a known issue without an official solution: browserify/browserify#1151.
http://stackoverflow.com/a/28176927 provides some workaround suggestions.

from particle-emitter.

marekventur avatar marekventur commented on May 19, 2024

I didn't expect that. Thanks for digging this out, I'll see what I can do. I guess this means I can close this issue?

from particle-emitter.

andrewstart avatar andrewstart commented on May 19, 2024

Yep, although would like to know which workaround works best (for you).

from particle-emitter.

marekventur avatar marekventur commented on May 19, 2024

I'll keep you posted - although I doubt I'll have much time to poke it this week :(

from particle-emitter.

hypercross avatar hypercross commented on May 19, 2024

it's 2017, and seems like browserify would need a derequire pass to rename all require() calls in the bundle so that browserify skips module loading.

from particle-emitter.

kribblo avatar kribblo commented on May 19, 2024

derequire added in 2.1.7, see if that helps?

from particle-emitter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.