Comments (6)
Thanks for the detailed bug. That makes sense. Will look at it soon
from sound.
I'm having some issues creating a fork right now, but this snippet seems to have fixed this issue in sound v4 in my project:
import { webaudio } from '@pixi/sound';
webaudio.WebAudioInstance.prototype.stop = function(){
if (this._source)
{
this._internalStop();
}
this.emit('stop');
}
from sound.
I'm seeing this same issue, though my repro steps are slightly simpler
- call
pauseAll()
- call
stop()
on a specific sound instance - call
resumeAll()
I believe what's happening is that when pause()
is called on a sound, it's _internalStop()
is getting called, which is nulling this._source
, so when stop()
gets called while the sound is already paused, it checks if this._source
exists, it doesn't, and then nothing happens. I think if we were to emit the 'stop' event any time stop()
gets called, regardless of whether _source
exists, Sound
should trigger _onComplete()
and clean up any instances still in the _instances
array.
I've only looked at the v4 code, but here's the instance stop:
sound/src/webaudio/WebAudioInstance.ts
Lines 111 to 115 in a84c214
and here's the _onComplete:
Lines 766 to 776 in a84c214
from sound.
I'm having the same issue, is there an ETA for the fix? Version 5.2.3.
Thank you!
from sound.
I did some digging and problem seems to be lying in refreshPause
calls.
@nicolasalt Can you try changes from PR #270 a few times locally? It might be a candidate for fixing the issue.
from sound.
I've tried but your PR is on top of pixi/sound v6.0 which depends on pixijs v8, while I'm using pixijs v7.2.4.
from sound.
Related Issues (20)
- Does the new @pixi/assets loader support loading sounds? HOT 2
- Version 5 error HOT 2
- Problem with dependencies v5.0.0 HOT 1
- Assets Loader with Sound should use the exact order of the audio formats defined HOT 2
- Format fallback with different filename bases HOT 1
- Not able to load base64 sound assets on production HOT 8
- v4.x doesn't respect `utils.supported`, which loads everything in `utils.extensions` anyway HOT 2
- Bug: Failed to set the 'buffer' HOT 4
- undefined is not an object (evaluating 'this.find(t).play') HOT 1
- Sound is suspended while window loses focus HOT 6
- `disableAutoPause` doesn't disable auto-resume HOT 4
- Sound does not work well on some browsers on iOS HOT 4
- Parser for Pixi Assets does not register properly HOT 2
- Uncaught TypeError just by following the Tutorial HOT 2
- Sine tone generated is one octave too low
- [bug] HTMLAudioInstance.ts HOT 2
- Safari Changing to different tab not muting sound HOT 1
- global sprite aliases?
- Pause/Resume Bug in PixiJS Sound v4.4.1 Causes Unexpected Spritemap Behavior
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sound.