Comments (6)
thank you for reporting.
it looks like your h3 input 847b59dffffffff
is at resolution 4 (bigger area)?
https://h3geo.org/docs/core-library/restable/
what the library currently does at h3 cell resolution 10 8a7b59dffffffff
from placekey-js.
perhaps you can tell us how you get the h3 input - that might point us to the reason
from placekey-js.
That particular H3 index was one of the ones we have in our system; I just started testing the Placekey API with it.
what the library currently does at h3 cell resolution 10
Does this mean that Placekey only works with indexes that are of resolution 10?
from placekey-js.
that particular behavior might be undefined - we might not have discussed what should happen if an user provide a h3 cell (I assume it should snap to the resolution 10 cell)
as of now Placekey is at res 10. its design can handle res 10-12. if you need a bigger area, have you consider https://h3geo.org/docs/api/regions/ ?
from placekey-js.
We don't need a bigger area for our purposes. Mostly our H3 indexes are stand-ins for actual lat/longs so scaling them down is easy.
Placekey not supporting resolutions higher than 10 is fine. But this behaviour isn't showing that. Placekey will happily generate a valid-looking Placekey value from an H3 index of resolution 4. But Placekey can't take this valid-looking value and turn it into a valid H3 index; instead it returns a garbage value. Better behaviour would be:
- If Placekey is intentionally not supporting H3 resolutions larger than 10, than either return
null
or throw an exception when receiving one. - Placekey's API should never return an invalid Placekey.
- If there is such a thing as an invalid Placekey, then there should be an API that I can call to determine whether a Placekey is valid or not. So far I don't see one, and so there's no way for me to tell whether the Placekey I've generated is valid or not.
- If I do pass an invalid Placekey in to
placekeyToH3
, it should returnnull
or throw an exception, not return a result. placekeyToH3
should never be returning invalid H3 indexes.
from placekey-js.
@isaacbrodsky - thoughts?
from placekey-js.
Related Issues (2)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from placekey-js.