Giter VIP home page Giter VIP logo

Comments (6)

bvenners avatar bvenners commented on May 28, 2024

We did this quite a long time ago. Let me track down the release number and I'll post it here.

from scalatestplus-play.

cjwebb avatar cjwebb commented on May 28, 2024

#21 mentioned the same thing, and says that release number 1.4.0-M4 contains the change.
I can confirm that it is working.

from scalatestplus-play.

thesamet avatar thesamet commented on May 28, 2024

1.4.0-M4 has it. Thanks!

from scalatestplus-play.

regispl avatar regispl commented on May 28, 2024

Hey guys, what's the story with that Issue? I can see that in other issue @bvenners wrote:

I have released 1.4.0-M4 with FakeApplication changed into Application.

But when I'm looking at master branch I can still see app being FakeApplication rather than Application in e.g. OneAppPerSuite:

https://github.com/scalatest/scalatestplus-play/blob/master/src/main/scala/org/scalatestplus/play/OneAppPerSuite.scala#L126

Is this something that's going to be fixed by any chance? If not, what's the other, nice way I can build my own Application using Guice Builder and use it together with ScalaTest+Play?

from scalatestplus-play.

cjwebb avatar cjwebb commented on May 28, 2024

Good question.

1.4.0-M4 definitely has the change, and is working. I'm using that version. I'm not sure how to find the corresponding commits on Github, but you can download and inspect the sources from Maven Central.
http://search.maven.org/#artifactdetails%7Corg.scalatestplus%7Cplay_2.11%7C1.4.0-M4%7Cjar

Maven Central also have a version 1.5.0-SNAP1, but that doesn't have the change :( Hopefully whenever a new final version is published it'll all be okay!

from scalatestplus-play.

regispl avatar regispl commented on May 28, 2024

Thanks, it seems to be fixed there, cool!
It looks like the 1.4.0 release is based on wip-play-2.4 branch and that change is applied there 👍

https://github.com/scalatest/scalatestplus-play/blob/wip-play-2.4/src/main/scala/org/scalatestplus/play/OneAppPerSuite.scala#L126

from scalatestplus-play.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.