Support functions from "scales" package about plotly.r HOT 4 CLOSED

hi @mkcor - did you need help with this?

from plotly.r.

We're not sure about adding the "scales" dependency... Do you have an opinion?

Thanks for checking in!

from plotly.r.

@mkcor depends on how you use functions from scales i think.

Do you mean to expose them to users? Or just use functions from scales internally?

scales is maintained by Hadley, so I would imagine it's a dependable piece of software, if quality is a concern

from plotly.r.

ggplot2 imports scales, so users need scales installed in order to install ggplot2. All users have to do is respect namespaces in the same way as if they were using ggplot2 directly.

library(plotly)
p <- ggplot(iris, aes(x = Sepal.Length, y = Petal.Width/Petal.Length)) + geom_point() +
  scale_y_continuous(labels = scales::percent_format())
ggplotly(p)

Depending on scales (that is, attaching the scales namespace when loading the plotly library) is a bad idea IMO

from plotly.r.