Comments (7)
from docker-letsencrypt.
I've was planning on building something quite similar to this so I used this is a starting point.
Here's what I added/changed...
- Made the changes to get it working with multiple domains and Ingress.
- Added a health check on / so that it returns 200 OK.
- Updated the kubectl version to be in line with docker best practice and make updating easier.
- I made the secret unique per domain and made it customizable
I'd be glad to contribute back some of what I've done if interested...
My plans are to make this more dynamic such that on a service that you want to have SSL, simply add a label and it will dynamically get picked up and handled.
https://github.com/phutchins/kubernetes-ssl-manager
from docker-letsencrypt.
@phutchins sounds fantastic. Please do contribute back and I'll happily test and merge.
from docker-letsencrypt.
from docker-letsencrypt.
@alexcouper Something tells me that it depends on implementation. There are different types of ingress controllers available: GCE, Nginx.
I think config reloading on certificate change should be part of their job and not this package.
Alternatively, we could create new secret (in format $SECRET_NAME_<timestamp>
) when certs are updated and simply patch Ingress resource with a new value. Old secrets should not be a problem, since K8S 1.3 will come with garbage collector of unused Secrets and ConfigMaps.
from docker-letsencrypt.
true that would work.
The other thing that had concerned me was not knowing how to route through to letsencrypt pod for some requests (like is done in nginx-ssl-proxy) - but I see now that this is entirely possible using the nginx ingress controller
So in summary, go for it, looking forward to seeing the PR!
from docker-letsencrypt.
Part of this has been done in #13 (including the new data keys in the secret)
from docker-letsencrypt.
Related Issues (9)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from docker-letsencrypt.