Comments (6)
I think this should probably be the responsibility of the individual bot to handle, since it makes it possible to log and handle messages from users who have been muted - presuming there's a way in the API to determine that.
I'm not sure why there's temptation to give an online community hell by spamming just because an exploit was found.
from plugapi.
There is a mutes object in PlugAPI but iirc it does not have a way of auto updating on mute / unmute nor has the API to mute / unmute been added to PlugAPI yet. This is plug's fault for client side checking the mutes object. I'm not 100% sure but even if plugAPI does check for mutes the same way plug does, how does that solve the issue of the exploit? The user can still send the chat since when a person is muted their input box for chat is disabled with a label stating how long they're muted. What that exploit does is empty the object and delete the interval the person is muted for to bypass it and allow the person to still send chat. As @avatarkava said there is perhaps a way for individual bots to handle it and i have an idea based on what i used to do before plug added muting. A command to delete / undelete chat from a user by adding to an array and then in the chat event checking an array of id's and if it matches delete that chat. Might be a bit of a hassle but that seems to be a good solution for now maybe.
from plugapi.
No, no. I mean, I don't think there is a way to check whether a client is muted or not in PlugAPI and even if there was, checking it every single message would be damn inefficient. Normally users wouldn't encounter this error because the API they would use for their bot wouldn't ever send the bot the message. Therefore it is still an issue for PlugAPI's side rather than plug's, although it is also plug's fault for not checking ANYTHING server side.
from plugapi.
There IS a way to check with plugAPI though, it just hasnt been implemented as of yet. There are event listeners in place for modMute and modUnmute but they have not been setup to properly update the object in room.js. but we have yet to add moderateMute , moderateUnmute and the updating of the mute object in room.js . This is still very much a work in progress.
from plugapi.
@TATDK I believe this issue can be closed, seeing as plugAPI has added mutes and the mute object.
from plugapi.
Yeah, thanks for reminding me
from plugapi.
Related Issues (20)
- Errors in callback functions passed to playlist methods are mishandled HOT 2
- Should treat URLs as atoms when splitting long chat messages HOT 5
- Use ES6 Promise in place of callbacks HOT 5
- The advance event when last DJ finishes has djs.length == 2 HOT 2
- getPlaylists callback argument is not a RESTCallback HOT 6
- Chat events mentions are always [] HOT 3
- Duplicate advance event on skip (some times) HOT 2
- Playlist management functions some times silently fail HOT 5
- Cannot read property 'length' of undefined HOT 3
- Bot gets 403 error, restarts at random intervals HOT 7
- addToWaitList throws 403 error when target user has no playlists HOT 3
- Errors trying to perform npm install plugapi HOT 2
- Error after connection with account without playlist HOT 2
- Not sure if playlist functions are working properly
- Unsupported events
- User.language is null HOT 2
- Room Description HOT 8
- Convert name to ID? HOT 8
- Have a bot.
- I'm using your api for a plug bot
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from plugapi.