Giter VIP home page Giter VIP logo

Comments (11)

travisterwilligar avatar travisterwilligar commented on May 23, 2024

Same issue for me. Thanks for pointing out your workaround!

from jekyll-bootstrap.

travisterwilligar avatar travisterwilligar commented on May 23, 2024

Actually - here's how to do it. The default template explicitly declares the theme in the YAML front matter as:

theme :
name : design-co

Include that in your layout and you should be golden.

from jekyll-bootstrap.

daithi-coombes avatar daithi-coombes commented on May 23, 2024

I am having the same issue. I've placed a png in:

assets/themes/my-theme/images/foo.png

but {{ ASSET_PATH }} only prints out: `assets/themes//images/foo.png

I have the YAML front matter in the theme, I'm hoping to make my theme public so manually declaring the theme asset location in the _config.yml is not an option

from jekyll-bootstrap.

daithi-coombes avatar daithi-coombes commented on May 23, 2024

the issue appears to be in _includes/JB/setup

The var page.theme.name is empty, so the ASSET_PATH is not getting set with the theme name

from jekyll-bootstrap.

intco avatar intco commented on May 23, 2024

+1

from jekyll-bootstrap.

LukasKnuth avatar LukasKnuth commented on May 23, 2024

Still an issue... Just as @daithi-coombes described it.

from jekyll-bootstrap.

fujii avatar fujii commented on May 23, 2024

I created a patch.
https://github.com/fujii/jekyll-bootstrap/commit/16e8a9d10259e4665534825422ec05b704f7114d

from jekyll-bootstrap.

leompeters avatar leompeters commented on May 23, 2024

+1

from jekyll-bootstrap.

groundh0g avatar groundh0g commented on May 23, 2024

Housekeeping. I'll review the comment stream and @fujii's tweak. Will create PR after review / testing.

from jekyll-bootstrap.

groundh0g avatar groundh0g commented on May 23, 2024

OK. Discussion time. The fix from @fujii works as expected. There's one snag, though. And I don't think it's a show-stopper. Somewhat related to #227, but barely.

There's an issue with variable scope and ASSET_PATH. The fix will allow the themes to access assets using the variable, but actual posts, drafts, and pages won't have a valid ASSET_PATH. And I'm not 100% convinced that they need it.

Happy Path (for templates):

jb-setup-happy-path

Gray Area (for posts, pages, and drafts):

jb-setup-ruhoh-path

If that's not an issue for you guys, I'm fine with just sticking a footnote somewhere that says that ASSET_PATH is only valid for themes. Pages, posts, and drafts are on their own.

from jekyll-bootstrap.

groundh0g avatar groundh0g commented on May 23, 2024

Tested without issue. No activity on comments. Merged.

from jekyll-bootstrap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.