Comments (11)
Same issue for me. Thanks for pointing out your workaround!
from jekyll-bootstrap.
Actually - here's how to do it. The default template explicitly declares the theme in the YAML front matter as:
theme :
name : design-co
Include that in your layout and you should be golden.
from jekyll-bootstrap.
I am having the same issue. I've placed a png in:
assets/themes/my-theme/images/foo.png
but {{ ASSET_PATH }}
only prints out: `assets/themes//images/foo.png
I have the YAML front matter in the theme, I'm hoping to make my theme public so manually declaring the theme asset location in the _config.yml
is not an option
from jekyll-bootstrap.
the issue appears to be in _includes/JB/setup
The var page.theme.name
is empty, so the ASSET_PATH is not getting set with the theme name
from jekyll-bootstrap.
+1
from jekyll-bootstrap.
Still an issue... Just as @daithi-coombes described it.
from jekyll-bootstrap.
I created a patch.
https://github.com/fujii/jekyll-bootstrap/commit/16e8a9d10259e4665534825422ec05b704f7114d
from jekyll-bootstrap.
+1
from jekyll-bootstrap.
Housekeeping. I'll review the comment stream and @fujii's tweak. Will create PR after review / testing.
from jekyll-bootstrap.
OK. Discussion time. The fix from @fujii works as expected. There's one snag, though. And I don't think it's a show-stopper. Somewhat related to #227, but barely.
There's an issue with variable scope and ASSET_PATH. The fix will allow the themes to access assets using the variable, but actual posts, drafts, and pages won't have a valid ASSET_PATH. And I'm not 100% convinced that they need it.
Happy Path (for templates):
Gray Area (for posts, pages, and drafts):
If that's not an issue for you guys, I'm fine with just sticking a footnote somewhere that says that ASSET_PATH is only valid for themes. Pages, posts, and drafts are on their own.
from jekyll-bootstrap.
Tested without issue. No activity on comments. Merged.
from jekyll-bootstrap.
Related Issues (20)
- Theme breaks when viewing an added post (following "quick start" in manual) HOT 2
- Can't include theme in posts HOT 3
- ERROR `/assets/themes/bootstrap/css/bootstrap.min.css' not found HOT 8
- it show in my local server but doesn't work in github pages
- The built-in Disqus now requires visitors to load unsafe scripts on https in order to comment. HOT 4
- Integrate Font Awesome release 4.6
- Page layout is broken HOT 5
- Support Bootstrap 4
- syntax highlighting not working HOT 1
- cant switch themes
- not manageable
- the resource path is wrong HOT 4
- Themes not working HOT 2
- Nested list does not work HOT 1
- Sorry this page does not exist =( HOT 3
- http://jekyllbootstrap.com is 404 HOT 2
- themes.jekyllbootstrap.com does not load HOT 1
- _config.yml changes are not reflecting on generated website.
- ERROR `/assets/themes/bootstrap-3/bootstrap/css/bootstrap.min.css' not found. HOT 1
- Malware?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jekyll-bootstrap.