Setup Vercel automatic deployments for Pull Requests about react-three-rapier HOT 10 CLOSED

tsc also crashes locally for me so at least that’s not nexts fault. Thanks!

from react-three-rapier.

The demos are really only a test-bed for debugging currently, not exactly intended for public consumption.
Since the /demo is relying on preconstruct I'm not sure how that would work in a vercel-setting 🤔

What I really want is some CodeSandbox examples for these things.

from react-three-rapier.

@isaac-mason For sure! Help always appreciated. I'm spending most of my time working on the API when I get chances.

from react-three-rapier.

Thanks for helping with this!
I'll clear up the tsc issues for the demos.

From what I can tell the https://react-three-rapier-git-feat-deprecate-hook-api-pmndrs.vercel.app/, which should be based on the branch, is actually using what looks to be the latest published version of r3/rapier -- so the Kinematics-demo does not work accurately (the torus should be spinning in the latest version).

Defeats the purpose of the preview deployments. Anything that can be done there?

from react-three-rapier.

Redeployed this now: https://react-three-rapier-git-feat-deprecate-hook-api-pmndrs.vercel.app/

@wiledal let me know if that looks right 🙂

from react-three-rapier.

Yes! Looks good!

Closing this thread 🤝 🥳

from react-three-rapier.

Vercel should work fine with anything - you can supply any bash command for your build and a directory to upload.

CodeSandbox examples are probably more ideal for public demos, but I personally also find having built examples in PRs handy.

I'm happy to lend a hand setting it up if you're keen 🙂

from react-three-rapier.

@Glavin001 @isaac-mason i added it to next https://react-three-rapier.pmnd.rs/ but do you know why it chokes on "@react-three/rapier: "*" in package.json? with preconstruct this is how it's supposed to be but next seems to dislike it. i added a hacky yarn add @react-three/rapier to the build config, that's why it "works" but it should be able to pull in from /src.

from react-three-rapier.

@drcmda should be fixed now!

I had to change the root directory from demo to the repo root & update the output folder.

Then changed the build command to this:

yarn build && cd demo && npx vite build

Ideally we'd also run tsc (part of the demo package yarn build) to type check but there are some type errors right now.

from react-three-rapier.

No worries!

With my change, new deployments should use the @react-three/rapier build from the branch - I'll see if I can re-run that preview deployment to make sure!

from react-three-rapier.