Giter VIP home page Giter VIP logo

Comments (4)

ryanking1809 avatar ryanking1809 commented on May 5, 2024 4

Perfect, that does the trick! Thankyou!

from zustand.

Magellol avatar Magellol commented on May 5, 2024

I think it might be because you don't have a key on each element. React uses keys to know which item has changed or has been removed/added to the list. Without a stable identity, it doesn't know and renders everything again.

<div className="App">
  {divs.map((d, i) => (
-    <DivEl color={d} index={i} />
+    <DivEl color={d} index={i} key={i} />
  ))}
</div>

Now using indexes as keys is not always good, it depends if the items in the list will have their order changed eventually. In that case you might need something that is uniquely tied up to each item.

from zustand.

ryanking1809 avatar ryanking1809 commented on May 5, 2024

Sorry, that was clumsy of me, but the keys don't make a difference. I've updated the codesandbox above and all items still rerender when only one item has changed.

from zustand.

Magellol avatar Magellol commented on May 5, 2024

Sorry I got confused as well :). Not having stable keys would actually force React to destroy and create items on each render pass because it doesn't know which items got updated/added/removed since the keys are different (or no keys at all).

The fact that all DivEl re-renders is normal because its parent re-renders due to the Divs state slice to update in the store. To avoid unnecessary renders, we can leverage memo which would do a shallow equal comparison on the props and abort rendering if they haven't changed.

I forked your sandbox and used memo: https://codesandbox.io/s/musing-curran-gwnor

from zustand.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.