Giter VIP home page Giter VIP logo

Comments (14)

pnedev avatar pnedev commented on July 30, 2024

Yes, indeed. Thanks.

from compareplus.

pnedev avatar pnedev commented on July 30, 2024

Hello Yaron,

This is fixed in master branch. NavBar can be further optimized but that is another matter.
Closing this now.

BR

from compareplus.

Yaron10 avatar Yaron10 commented on July 30, 2024

Hello Pavel,

Great. Thank you.

I really don't know how the NavBar should work and display the overall diffs.
As for this issue: unchecking “Ignore Spacing” and comparing the files in Test.zip, I get a different image than both posted by Doutei. :)

Best regards.

from compareplus.

pnedev avatar pnedev commented on July 30, 2024

Hello Yaron,

Yes, there are still some issues. I'll check that.
Thanks.

BR

from compareplus.

Yaron10 avatar Yaron10 commented on July 30, 2024

Thank you Pavel. I appreciate it.

BR

from compareplus.

pnedev avatar pnedev commented on July 30, 2024

Hello Yaron,

One a bit "strange" question - What is the resolution of your monitor?

The current NavBar looks exactly as the first image from Doutei if you have a vertical resolution greater than the number of lines in the compared documents (the bigger number from the two).
This is because each vertical pixel in the NavBar bitmap currently represents one line from the compare and if you have less vertical screen resolution than the compared lines some get overwritten.
This is a problem of course and as I said there are still some issues and things to be fixed. I just wanted to clarify :)

BR

from compareplus.

Yaron10 avatar Yaron10 commented on July 30, 2024

Hello Pavel,

Thank you for everything.
Just when we get to the interesting part (the Compares and layout handling; - not the NavBar) I hardly have a free minute.
Tomorrow I probably won't be by a PC. I'm looking forward to Friday. :)

My resolution is 1360x768.

The "Select First" is a truly brilliant idea.
How about "Compare current to last active"?

I'll elaborate on that and other issues.

Best regards.

from compareplus.

pnedev avatar pnedev commented on July 30, 2024

Hello Yaron,

Don't worry, we'll discuss things further when you have time, thanks.

How about "Compare current to last active"?

I see what you mean. That's interesting but I think it might get a bit confusing for the user and it will add another compare command to the plugin menu (which seems a bit too much).

BR

from compareplus.

Yaron10 avatar Yaron10 commented on July 30, 2024

Hello Pavel,

Some screenshots of the NavBar on my machine.

Thank you.

BR

NavBar.zip

from compareplus.

pnedev avatar pnedev commented on July 30, 2024

Thank you, I'll investigate it sometime in the future.

BR

from compareplus.

Yaron10 avatar Yaron10 commented on July 30, 2024

Great. Thank you.

BR

from compareplus.

pnedev avatar pnedev commented on July 30, 2024

Hello Yaron,

I've made a lot of modifications and optimizations to the NavBar and basically it should be functional and working OK now. There might still be some issues but nothing critical I hope. I'll clean them regularly as those pop-up, thanks.
I'm closing this issue now.

BR

from compareplus.

Yaron10 avatar Yaron10 commented on July 30, 2024

Hello Pavel,

As you know I hardly use the NavBar.
Anyway - using Doutei's comment and images as a reference point, your work seems great as always. :)

Thank you very much.
BR

from compareplus.

pnedev avatar pnedev commented on July 30, 2024

Thanks Yaron.

BR

from compareplus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.