Giter VIP home page Giter VIP logo

Comments (8)

pnedev avatar pnedev commented on July 30, 2024

Hello Yaron,

Let me first re-enable the multiple compares, things will be different after that.
We'll double check then this test case, thanks.

BR

from compareplus.

Yaron10 avatar Yaron10 commented on July 30, 2024

Hello Pavel,

I think the broader question is what "Clear Results" should do if there are multiple Compares in the active window.

Clear all Compares?
If so, the problem is not that the views are not synced but rather that the diff marks are not cleared.
Also, the user might want to clear only one Compare.

Clear only the visible Compare?
This means that If the user switches to a non-compared file, "Clear Results" should be disabled.

A setting for the preferred behavior?

Another option is not dealing with it and have some Known-Issues.
After all, it's not a professional Compare application. :)

Thanks again for your great work.

Best regards.

from compareplus.

pnedev avatar pnedev commented on July 30, 2024

Hello Yaron,

That's the main question indeed.
For now I thought to implement the

Clear only the visible Compare

variant.
We may as well add Clear all compares command.
What's your opinion on this?

BR

from compareplus.

Yaron10 avatar Yaron10 commented on July 30, 2024

Hello Pavel,

We may as well add Clear all compares command.

That would be the best solution. 👍
It seems that implementing this would require a lot of work.
I take my hat off even for suggesting it. :)

Thank you.

Best regards.

from compareplus.

pnedev avatar pnedev commented on July 30, 2024

Hello Yaron,

That shouldn't be that difficult after the refactoring.
Let's get there and we'll see.
Thanks for the feedback.

BR

from compareplus.

Yaron10 avatar Yaron10 commented on July 30, 2024

Hello Pavel,

That shouldn't be that difficult after the refactoring.

OK. :)

Thanks for the feedback.

My pleasure.
I'm impressed and even overwhelmed by the amount of work you've already accomplished.
Thank you!

Best regards.

from compareplus.

pnedev avatar pnedev commented on July 30, 2024

Fixed in master branch, thanks.

BR

from compareplus.

Yaron10 avatar Yaron10 commented on July 30, 2024

Great.
Thank you very much.

BR

from compareplus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.