Comments (12)
Hello Yaron,
OK, sounds reasonable, I agree.
BR
from compareplus.
Hello Pavel,
Thank you very much. I appreciate it.
BR
from compareplus.
Hello Yaron,
Implemented in master branch.
Original compared file save is also restored (code is optimized).
BR
from compareplus.
Thank you, Pavel. (CP 1d3e95a)
Great! My typical work flow is compare -> modify -> compare -> modify -> etc. This works a lot better without having to clear-compare before re-comparing.
To err is human, apparently I'm the most humane creature on earth. :) It's not uncommon that I unintentionally modify the base file, but fortunately NPP offers "Reload". I was wondering if it might be possible to re-compare automatically if one of the files involved in the compare is reloaded? It would seem to be reasonable and user friendly behaviour?
from compareplus.
Hello @xylographe ,
It's good that @Yaron10 brought the reload issue forward.
You both seem to be long time users of Compare plugin, it's great I can get suggestions/opinion from user perspective. Thank you both.
To err is human, apparently I'm the most humane creature on earth. :)
Long live humanity! :)
I thought about handling the reload case (in slightly different manner though - to close the current compare :)) but I haven't reached there yet. Automatic re-compare in that case seems reasonable, I'll consider it.
@Yaron10 , what's your opinion about that?
BR
from compareplus.
Hello Pavel and xylographe,
Pavel,
Thank you very much. I do appreciate it.
It's good that @Yaron10 brought the reload issue forward.
Thanks for that too. But unless I'm missing something, xylographe deserves the credit for raising the "Reload from disk" issue.
I was referring to "Reload last closed file" (or "Restore recent closed file").
Actually I do deserve some credit for "Reload from disk". I thought about it. :)
And then I thought about "File has been modified by another program. Reload?". (Related).
And what if the user deletes/replaces the entire content of a compared file? And what about a minor change?
Anyway - if addressing "Reload from disk" is important to xylographe, that's a good reason to implement it. :) We appreciate your work.
Thanks for bringing that up.
Best regards.
from compareplus.
Hello @Yaron10 ,
It's good that @Yaron10 brought the reload issue forward.
I didn't mean the reload but the "re-compare current compare", sorry for the confusion.
I must have been partly sleeping already when I wrote this ;)
@xylographe,
Thanks for bringing that up.
Can you open a new issue regarding the reload just to have this on record?
This issue was regarding re-compare and is closed. Thanks.
BR
from compareplus.
Hello guys,
Unfortunately N++ currently doesn't provide file reload notification. I'll see if I can do something anyway but it's going to take a while.
BR
from compareplus.
And then I thought about "File has been modified by another program. Reload?"
Well, in my case that would only happen if I decided to change the base file to an older/newer version by invoking "git checkout" (or "svn co"). My intention would still be the same: re-compare with the reloaded file to continue the work flow outlined above.
However, I understand other users might want to "Clear Compare" on a reload due to external modification. Combined with,
Unfortunately N++ currently doesn't provide file reload notification.
my conclusion has to be: do nothing, let the user decide if they want to continue with clear-compare or re-compare. Both of them are only one shortcut away…
@pnedev
Yes, I intended to open a new issue, just wanted to know if it was technically possible.
However, having read your and Yaron's comments, the planned issue has been closed before it has been created. :) Whichever automated action you would choose, there would always be a substantial number of disgruntled users. This would be a good candidate for "Options", but I'm aware (and understand) you'd rather not go that way.
Thanks to both of you for your input—it's always good to see matters from a different perspective.
from compareplus.
OK @xylographe , we'll leave that for the future then. Thanks.
BR
from compareplus.
Hello gentlemen,
And then I thought about "File has been modified by another program. Reload?". (Related).
And what if the user deletes/replaces the entire content of a compared file? And what about a minor change?
I didn't mean that in those cases the Compare should be cleared.
I was just wondering about dynamically re-comparing. Where do we draw the line?
Pavel may well be capable of implementing dynamically re-comparing ( :) ), but then Compare would have to compete with MS Visual Studio (in terms of dynamically detecting and responding to modifications).
Thank you.
BR
from compareplus.
Let's leave the reload and dynamic re-compare for the time all other issues are closed and we are all happy with the current state. Those are pretty tough tasks and will require more thought and concentration.
Thank you both for sharing your thought on the subject.
BR
from compareplus.
Related Issues (20)
- "Ignore Spaces" problem with "_" character? HOT 1
- app crashes on compare HOT 3
- how to save/export result as a html file? HOT 1
- Feature request - Jump to differences within the line HOT 15
- "Next" and "Previous" skip changed lines when they are right after one another HOT 1
- [FR] Quick Switch / Flip HOT 1
- Cannot download ComparePlus plugin ZIP from my work laptop (connected via VPN) HOT 10
- Ability to Copy-Paste only new or changed strings in Show Only Diffs (Hide Matches) mode HOT 2
- Where is dll for latest version? HOT 1
- Navigation bar not showing HOT 11
- How to view .diff single file as comparison in split view? HOT 1
- Compare only the 1st part of a line HOT 4
- After exiting compare, current selected line Colors/Linter is set to black instead of light grey. HOT 5
- Large file compare causing display issues HOT 3
- Add possibility to close both files after compare HOT 7
- Show Only Diffs (Hide Matches) doesn't work HOT 2
- Perfect match text with black highlights HOT 3
- New feature request: Merge changes HOT 1
- Make it possible to translate menus into French or any other language. HOT 6
- Copy/past hot keys HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from compareplus.