Giter VIP home page Giter VIP logo

Comments (5)

glennrp avatar glennrp commented on September 26, 2024

This is a known problem, fixed in libpng-1.6.29. It can be exhibited when linking libpng-1.6.28 with zlib-1.2.8f

from libpng.

selasley avatar selasley commented on September 26, 2024

I'm still getting this error with libping-1.6.29 and any zlib version above 1.2.8 in OS X 10.12, clang version Apple LLVM version 8.1.0 (clang-802.0.42) With zlib 1.2.8 installed, make completes without errors and make check passes all tests. I think the problem is the ZLIB_VERNUM check in pngrutil.c

If I change line 421 in pngrutil.c from
#if ZLIB_VERNUM >= 0x1290 &&
to
#if ZLIB_VERNUM < 0x1290 && \

make completes without errors and make check passes all tests with zlib 1.2.9 and 1.2.11 when making libping-1.6.29

from libpng.

glennrp avatar glennrp commented on September 26, 2024

That backslash is present in my copy of libpng-1.6.29.tar.gz and in pngrutil.c in the libpng16 branch of the github repository. The ">=" is correct, because inflateValidate() was added to zlib at version 1.2.9,
and 0x1290 is greater than your 0x128f.

from libpng.

selasley avatar selasley commented on September 26, 2024

I started with a fresh download of libpng-1.6.29 and was still getting the "Undefined symbols" error until I exported LDFLAGS="-L/usr/local/lib" before doing ./configure and make. I'd be happy to delete my earlier comment since it contains incorrect information.

from libpng.

jbowler avatar jbowler commented on September 26, 2024
If I change line 421 in pngrutil.c from
#if ZLIB_VERNUM >= 0x1290 &&
to
#if ZLIB_VERNUM < 0x1290 && \

and from the original report:

Undefined symbols for architecture x86_64:
  "_inflateValidate", referenced from:
      _png_inflate_claim in pngrutil.pic.o

So if ZLIB_VERNUM is = 0x1290 in the original code there is no call to inflateValidate in the libpng source code.

@lifeofguenter: please retest in the latest release of libpng.

from libpng.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.