Apple clang 8.1.0 warnings about libpng HOT 5 CLOSED

The warning messages hint that using "(void)" would suppress the warnings.

I suspect that in most cases the warning could also be suppressed
by using semicolons instead of commas, and adding braces
if necessary, as in

 if (test <= DBL_MAX)
          {
             ++exp_b10; base=test;
          }

in place of

 if (test <= DBL_MAX)
           ++exp_b10, base = test;

from libpng.

Yes, adding the curly braces and replacing commas with semicolons fixes these warnings, including the missing void warning - so no extra cast is necessary.

from libpng.

Issued two separate PRs to address the -Wcomma (#157) and -Wcast-qual (#158) warnings.

from libpng.

There was one special case regarding -Wcomma, in a while condition, here:
https://github.com/glennrp/libpng/pull/157/files#diff-4a3b03fdb4fb177ae3722ff381681441R1105

from libpng.

Closing this one in favour of the linked PRs.

from libpng.