Giter VIP home page Giter VIP logo

Comments (5)

yunnysunny avatar yunnysunny commented on September 24, 2024 1

@yunnysunny Does the new pnpmfile work? If it does, you should close this issue.

Thanks. It works ok now.

from pnpm.

KSXGitHub avatar KSXGitHub commented on September 24, 2024

Because your .pnpmfile.cjs is wrong. You are modifying the version field of [email protected], which doesn't magically turn [email protected] to your desired package. What you should do instead is changing the dependencies of packages that require typescript.

function readPackage (pkg) {
  const { dependencies, devDependencies, peerDependencies } = pkg
  if (dependencies?.typescript) dependencies.typescript = '4.9.5'
  if (devDependencies?.typescript) devDependencies.typescript = '4.9.5'
  if (peerDependencies?.typescript) peerDependencies.typescript = '4.9.5'
  return pkg
}

module.exports = {
  hooks: {
    readPackage
  }
}

Let me know if this works.

from pnpm.

KSXGitHub avatar KSXGitHub commented on September 24, 2024

Also, pnpmfile is overkill for this use case, the better solution is overrides:

{
  "pnpm": {
    "overrides": {
      "typescript": "4.9.5"
    }
  }
}

from pnpm.

yunnysunny avatar yunnysunny commented on September 24, 2024

I have change code to:

const versionNode = Number(process.version.split('.')[0].substring(1));

function readPackage(pkg, context) {
    const { dependencies, devDependencies } = pkg
    if (dependencies?.typescript) dependencies.typescript = '4.9.5'
    if (devDependencies?.typescript) devDependencies.typescript = '4.9.5'
    return pkg
}

module.exports = {
    hooks: {
        readPackage,
    }
}

I want to change some depenencies in opensource projects , which are tested among some old version nodes. It's not convenient for setting overrides in package.json .

from pnpm.

KSXGitHub avatar KSXGitHub commented on September 24, 2024

@yunnysunny Does the new pnpmfile work? If it does, you should close this issue.

from pnpm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.