dataframe display with blank white stripe about darkmode HOT 4 CLOSED

maybe we can use a styling like this

/* for the fixed header */
table.pluto-table .schema-names th, table.pluto-table .schema-types th:first-child {
    background-color: background_color;
}

/* for the rows numbers */
table.pluto-table tbody th:first-child {
    background-color: background_color;
}
/* for the hovering header*/
table.pluto-table .schema-types th {
    background-color: background_color;
    color: output_color;
}

Here's how it looks like

I'm just not sure how to PR this.

from darkmode.

Thanks guys! I've updated the styles to reflect these changes, they should be better now. @zuckberj your suggestions were good! CSS has a keyword called inherit for the things you were going for, and that did the trick. So you'd write background-color: inherit instead of background-color: background-color. I also credited you because your template did most of the heavy lifting :)

from darkmode.

Hey @Pocket-titan, thank you so much for the credits, it really feels good to be part of the community 😄

I tested the fix and I think we have a problem.

The inherit makes the bg color to be transparent.

Maybe we should use CSS variables to make things more customizable?

I will try to make a PR with this.

from darkmode.

@zuckberj Haha, no problem! And yes, I thought the table bg was the same color as the cell bg in the light mode, too? Or should they be different (& did I miss that completely 🙃)? You could try experimenting with stuff like hsla(0, 0%, 0%, 0.2) so it overlays, and tune the values a bit until it feels right to you. But css variables also work!

from darkmode.