Giter VIP home page Giter VIP logo

Comments (5)

ceztko avatar ceztko commented on June 12, 2024

Sorry, the page append/insert functions were taken from 0.9.x, renamed as per the API review and never tested again (I don't use them, nor they were unit tested in 0.9.x). I briefly looked at those functions and personally don't like the code there because it's hacky and I will rewrite them in the future, but it's not a priority for me right now. If you want to commit fixes for these functions please send me a PR with a trivial test case.

from podofo.

kovidgoyal avatar kovidgoyal commented on June 12, 2024

The insert function was reliably failing but the append seems to work
for me, so have simply removed use of insert. I dont know enough about
PoDoFo internals to patch these functions, so for the moment I will
leave it as is. If you do get around to refactoring these functions,
please start with append as it is more important for me.

from podofo.

kovidgoyal avatar kovidgoyal commented on June 12, 2024

Incidentally, is there a better alternative to append I should use if I want to combine two PDF files?

from podofo.

ceztko avatar ceztko commented on June 12, 2024

I think there isn't. Those functions are the correct ones for your use case.

from podofo.

kovidgoyal avatar kovidgoyal commented on June 12, 2024

See #85 for performance problems with append

from podofo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.