[GNOME40] Freezes gnome shell about no-title-bar HOT 14 OPEN

Sorry for the slow reaction!
I'm currently only using Xserver due to graphics card issues, so I might not have noticed myself. I will have a look into this on another device. Maybe somebody could have a look, if you can find any error in gnome's journal that might guide us the way to the error.

from no-title-bar.

I got an explanation why the system is freezing, because it's a sync call. Just call GLib.spawn_command_line_async (notice the 'a' almost in the end) and the system won't freeze anymore. The invocation of xprop won't work though in many cases, because it tries to talk to a XWayland that might not be running.

from no-title-bar.

Is there anything I am missing while installing this extension?

from no-title-bar.

I have the same problem. Installing the extension manually causes GNOME to freeze/crash every time I try to log in. This happens on a fresh Fedora 34 install using Wayland.

from no-title-bar.

Same issue here. I am able to log in normally, but as soon as I start the first application the gnome-shell freezes.

from no-title-bar.

I was using wayland in which if I enable extension I face this problem,

Here's what I could find in syslog I hope it helps in solving this issue,

Nov  1 20:13:56 blackdex gnome-shell[1458]: [no-title-bar] Init
Nov  1 20:13:56 blackdex gnome-shell[1458]: [no-title-bar] Enabling extension
Nov  1 20:13:56 blackdex gnome-shell[1458]: JS ERROR: Could not load extension [email protected]: Error: Missing metadata.json#012createExtensionObject@resource:///org/gnome/shell/ui/extensionSystem.js:284:19#012_loadExtensions/<@resource:///org/gnome/shell/ui/extensionSystem.js:592:34#012collectFromDatadirs@resource:///org/gnome/shell/misc/fileUtils.js:27:28#012_loadExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:572:19#012_enableAllExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:606:18#012_sessionUpdated@resource:///org/gnome/shell/ui/extensionSystem.js:637:18#012init@resource:///org/gnome/shell/ui/extensionSystem.js:57:14#012_initializeUI@resource:///org/gnome/shell/ui/main.js:278:22#012start@resource:///org/gnome/shell/ui/main.js:175:5#012@<main>:1:47

Currently after logging in Xorg session I'm not facing any freezing issue

from no-title-bar.

Hmm, I'm finding this hard to reproduce. I have installed a completely fresh Fedora 34 in a VM and only installed extension-tools and the extension itself (via make install) and it works flawlessly. Tested with: Gnome 40.4 running on Wayland and no other extensions active. Could you tell me more about your systems? Exact Gnome Version, other installed extensions, Distribution? I see, that it was not working on a clean Fedora 34 with Wayland, but I can't reproduce it on my end (at least not in the VM). Also is that everything you could retrieve from the journal before the freeze @yashoswalyo ? Could you maybe enable debug logging for the extension before activating it and try that again? You can find the option for that in the About-section of the extension's settings. Edit: The JS ERROR seems unrelated (something to do with Ubuntu's dash-to-dock?)

from no-title-bar.

I can confirm that the issue does not occur in a virtual machine.

I have just upgraded to Fedora 35 (Gnome 41.1, Wayland). When installing the extension from source via make install (and updating the manifest), the system freezes again on login. The system journal does not indicate any problems. Active extensions besides No Title Bar: gTile, Launch new instance (preinstalled), system-monitor, Workspaces Bar.

from no-title-bar.

Current state: Since I was unable to run Gnome Wayland 40 with my system, I had to update my Fedora to 35 with Gnome 41.1 which according to @joreiff did also show the same error. With Gnome 41 I can start a Wayland session, which I previously was unable to because of Nvidia's proprietary drivers not working particularly well with Gnome. Unfortunately I still cannot reproduce this problem. I have discovered some other problems, in particular firefox and chromium not getting undecorated, but other applications working without issue. Nevertheless, these seem like problems I might get around fixing, but while I cannot reproduce the freezing I am unable to do much about it. Would anybody with the problem be willing to debug that? It would already be helpful to know, where everything is dying (could probably be achieved with old reliable printf-debugging), so we know what to look for.

from no-title-bar.

Thanks for the update, @poehlerj! Last time I tried to debug on my Fedora 35 system, I lost all Gnome-related settings for some reason. So I do not want to continue debugging with this setup. However, I did test some things earlier today, and I was able to reproduce the issue with a Fedora live system. I will try to debug using that system once I find enough time.

from no-title-bar.

I was finally able to debug the freeze. I was able to narrow it down to two issues:

1. For some reason, no Displays are added to the Gdk.DisplayManager when Gtk is loaded. Consequently, Gtk.Settings.get_default() always returns null. This happens both with gjs-console and within the context of the shell extension. As a result, the extension is stuck in an infinite loop when loading the theme on startup. Interestingly, this issue does not occur with GTK's Python wrapper, which does correctly open the Display. Even more confusingly, GNOME's Looking Glass is aware of the Display. This issue can be circumvented by disabling the automatic theme selection.

2. The call to GLib.spawn_command_line_sync('xprop -root _NET_CLIENT_LIST') in Decoration._guessWindowXID does not return. I have no idea why this is the case, since the same code works as expected in both gjs-console and Looking Glass.

I have to admit that I ended up with more questions than I started with. Maybe @poehlerj or someone else can make some sense of this...

from no-title-bar.

I'm facing the same issue on a different extension and I've been able to narrow the issue to following call:

GLib.spawn_command_line_sync('gnome-terminal [...]')

from no-title-bar.

Interesting, thanks for your hints, @Silvanoc! Unfortunately, GLib.spawn_command_line_async does not allow reading stdout. Instead, GLib.spawn_async_with_pipes might be a better choice, although it requires more changes.

from no-title-bar.

I'm sorry for being absent so long. This problem is the one of the first symptoms, that this extension will be less useful in the future. Wayland uses a different approach to titlebars than xorg, in particular leaving it to the window to render its own titlebar, which is what more and more applications are doing. This way the applications can use the titlebar to include buttons and additional functionality. With wayland we have little issues like this, that will probably keep me from maintaining this extension for a longer time in the future. For now I'm trying to keep up with it, but I have to admit, that it gets more and more frustrating. Anyway, I have commited a potential fix in ad19eca, 30c317a and now will update to Gnome 42 and check compatibility there. The fix adds a timeout to the xprop command, which is problematic. If somebody can give me feedback, if the commits fix the problem (just checkout latest master), then I will release the next version (compatible with Gnome 40, 41 and 42) to extensions.gnome.org.

from no-title-bar.