Giter VIP home page Giter VIP logo

Comments (3)

stephencelis avatar stephencelis commented on September 16, 2024

Fixed by #22.

from swift-clocks.

bobergj avatar bobergj commented on September 16, 2024

@stephencelis I saw this was reverted: #26
but the revert doesn't provide a rationale. Doesn't reverted-to behaviour break the contract
of https://developer.apple.com/documentation/swift/task/sleep(until:tolerance:clock:), which is supposed to wake up at the deadline?

from swift-clocks.

stephencelis avatar stephencelis commented on September 16, 2024

@bobergj Sorry for not describing the problem, but the change broke existing test clock tests and made TestClock behave differently than other test clocks and schedulers out there, including our combine-schedulers test scheduler, as well as the test schedulers that come with RxSwift, ReactiveSwift, and more.

A clock should suspend when told to sleep, and should only resume when the test clock advances. We do not believe this behavior breaks the contract because the test clock does wake up at the deadline, it just needs to advance first, which is typically done by calling clock.advance() (which is an alias to clock.advance(by: .seconds(0))).

from swift-clocks.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.