Timeouts on WKWebView image snapshot about swift-snapshot-testing HOT 10 CLOSED

Ah. I think it’s kind of correct to fail in this case. Any way to modify your code to avoid the loading for the test? Or to load a valid HTML string instead?

from swift-snapshot-testing.

Ah, good point, embedded web views shouldn’t time out if possible. Will look into this soon! Thanks for so thoroughly testing things 🙌

from swift-snapshot-testing.

Applications I am covering now with snapshot tests (fortunately) have a lot of weird things 😅

from swift-snapshot-testing.

@kaqu I can't seem to reproduce this failure. WKWebView snapshots should only time out if the web view thinks that it isLoading. As long as the web view is not actively loading content, it should render a blank screen. Any chance you can produce a failing test case for us?

from swift-snapshot-testing.

Ok, I will try to reproduce it outside or find if there is some other case here.

from swift-snapshot-testing.

This makes timeout:

func testWebView() {
        class VC: UIViewController {
            override func loadView() {
                let browser: WKWebView = .init()
                view = browser
                browser.load(URLRequest(url: URL(string: "url")!))
            }
        }
        let vc = VC()
        vc.view.frame = .init(x: 0, y: 0, width: 200, height: 200)
        assertSnapshot(matching: vc, as: .image)
    }

It turns out that it was loading url, but it was kind of invalid.

from swift-snapshot-testing.

I am wondering if loading other valid URL like base64 data which is accepted by browsers will behave similarly.

from swift-snapshot-testing.

(Up for other suggestions, too! We just want to wait for loading web pages to load.)

from swift-snapshot-testing.

Thanks for help though, sorry for incomplete debug 🙂 I agree that timeout in that case is good (loading base64 data seems to work correctly)

from swift-snapshot-testing.

Going to close this issue and track the improvement here #136.

from swift-snapshot-testing.