Giter VIP home page Giter VIP logo

Comments (13)

evanshultz avatar evanshultz commented on June 22, 2024

Did you install a YAML parser? Use pip to snag one. I think I used pyyaml.

Also, which version of Python are you using?

from kicad-footprint-generator.

gcormier avatar gcormier commented on June 22, 2024

I ran manage.sh update_dev_packages which installed the required dependencies I think? In anycase, pyyaml is already installed.

Python 3.7.2

from kicad-footprint-generator.

evanshultz avatar evanshultz commented on June 22, 2024

Well dang. I get the same result. @antoniovazquezblanco ? I'm out of time today but can look at this tomorrow if Antonio doesn't answer.

Can you run other scripts? The other Harwin one doesn't work for me but conn_jst_eh_tht_side.py in the Connector_JST folder does.

I'm also on 3.7.2.

from kicad-footprint-generator.

gcormier avatar gcormier commented on June 22, 2024

Yup, that one worked, although warnings about safe load, and also

Invalid -W option ignored: invalid module name: 'yaml'

from kicad-footprint-generator.

gcormier avatar gcormier commented on June 22, 2024

#320 for when things are semi-functional.

Dunno how I feel about the detailed silk screen... also, Samtec offers 4 pin lengths, also unsure how to handle. Perhaps a graphical display with 4 lines indicating the different offsets? But keep the traditional/most common depth?

Quick example:

image

from kicad-footprint-generator.

evanshultz avatar evanshultz commented on June 22, 2024

Fixed both Harwin script issues at #322.

On pin length, I have two proposals. Our library is big enough to support many footprints, but since it's also general-purpose I'm inclined to support the greatest number of footprints possible.

  1. Just make the one you want.
  2. Build the longest one and then shorter ones will fit inside. This is the lowest common denominator approach. I favor this for our library if it works for you.

from kicad-footprint-generator.

gcormier avatar gcormier commented on June 22, 2024

Sweet, that'll get me tinkering.

My issue with option 2 is that I bet 99% will use the standard length. Building the longer one will waste space for most people designs.

Another thought:

This connector would very likely be at the edge of the board, or if not, it would need to have quite a bit of space left in front to allow for plugging in of the header.

The pin outline could reflect the standard pin length, but the courtyard could reflect the longest pin length? For something overhanging the edge of the board, the courtyard would have no ill effect. Of course it would violate KLC, which might bring us back to option 1 which is the one I want :)

from kicad-footprint-generator.

gcormier avatar gcormier commented on June 22, 2024

Okay, so I had an issue with the pin 1 silkscreen.

image

I changed a few lines, from 6.775 to 6.98

	s_pin1 = [
        {'x': -6.98+padsize[0]/2-(2.5/2+configuration['silk_pad_clearance']+configuration['silk_line_width']), 'y': -(pitch*(pinnum-1))/2},
        {'x': -6.98+padsize[0]/2-(2.5/2+configuration['silk_pad_clearance']+configuration['silk_line_width']), 'y': -(pitch*(pinnum-1))/2-1/2-configuration['silk_line_width']-configuration['silk_pad_clearance']},
        {'x': -6.98+padsize[0]/2, 'y': -(pitch*(pinnum-1))/2-1/2-configuration['silk_line_width']-configuration['silk_pad_clearance']},
	]

Looking better. That number 6.775 is everywhere. And then I noticed the silkscreen for the pins is off as well.

image

So it leads me to believe perhaps I need to be fixing it elsewhere? Or is this just part of the game?

I do notice a silkscreen pad offset, but can't find that configured anywhere, and perhaps I don't want to touch that.

from kicad-footprint-generator.

gcormier avatar gcormier commented on June 22, 2024

For reference
image

from kicad-footprint-generator.

gcormier avatar gcormier commented on June 22, 2024

A few tweaks, latest commit has this coming out the other end

image

from kicad-footprint-generator.

gcormier avatar gcormier commented on June 22, 2024

Thoughts on this? Should I submit a PR for continued discussion in kicad-footprints ?

from kicad-footprint-generator.

evanshultz avatar evanshultz commented on June 22, 2024

The courtyard should match the footprint.

Good catches on the silkscreen. Magic numbers are no good, especially if it's used all over the code. You will want to keep 0.12mm or more clearance from pads to silk, which turns into 0.18mm since you need to consider half of the silk line width (or the endcap radius). If there is a silkscreen pad offset not being used, it seems like a good variable name so put it to use or remove it so nobody else is confused in the future.

Script quality can vary, and the framework sometimes changes, so it may take a bit of work to start with an existing script and end up with something nice. Great work!

The screenshots above look OK, but in this case a footprint PR with all the parts to view in KiCad and a script PR will be the best way to get this reviewed and merged.

from kicad-footprint-generator.

gcormier avatar gcormier commented on June 22, 2024

I'll get a PR going.

RE: Courtyard, I followed KLC for a connector. One might argue that the pin-side should be even bigger to allow mating?

Connectors should have a clearance of 0.5mm, in addition to the clearance required for mating of connector

from kicad-footprint-generator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.