Giter VIP home page Giter VIP logo

Comments (3)

mcrumiller avatar mcrumiller commented on June 5, 2024 1

No, the syntax works fine. I agree that the imports are a little ambiguous. The way the docs are set up is that the code snippets are actually .py files that are run, and the output is displayed in the docs.

When I said it needs updating, it's mainly because 1) the import isn't identified anywhere in the docs, which can be a source of confusion, and 2) the age calculation is incorrect. I don't know making it correct is worth it though, we can see what others would say.

from polars.

mcrumiller avatar mcrumiller commented on June 5, 2024

Yikes, yeah that needs updating, and the formula will not correctly compute the age. Quick help though: the date is a datetime.date object, which does have the year property:

from datetime import date  # see here
import polars as pl

def compute_age():
    return date(2021, 1, 1).year - pl.col("birthdate").dt.year()

df = pl.DataFrame({
    "birthdate": [date(1950, 1, 1)],
})

df.select(compute_age())
shape: (1, 1)
┌─────────┐
│ literal │
│ ---     │
│ i32     │
╞═════════╡
│ 71      │
└─────────┘

from polars.

Lvulis avatar Lvulis commented on June 5, 2024

Ah, thanks! That makes way more sense. Is the need for an update because of the overall syntax?

Also, I'm revisiting reading through docs after the holidays and just had this doc open so jogging my memory here. I see date and datetime are imported from datetime in the Column Selections subchapter/section. Would it make sense to add an explicit import call to datetime on this page as well?

from polars.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.