Giter VIP home page Giter VIP logo

Comments (3)

ritchie46 avatar ritchie46 commented on June 27, 2024

What is counter-intuitive? We don't have a notion of null rows, so we cannot make an ignore_nulls argument. They behave different and count will not be exposed as a general catch all.

That's why we only expose it on Expr. And pl.len() will be exposed as a catch all. They are different for a reason.

from polars.

mcrumiller avatar mcrumiller commented on June 27, 2024

Everything conforms to how the documentation specifies.

import polars as pl
from polars import col

df = pl.DataFrame({"a": [1, 2, None]})

df.select(pl.count())              # returns 3 (counts all rows)
df.select(pl.count("a"))           # returns 2 (counts non-nulls only)
df.select(col("a").count())        # returns 2 (counts non-nulls only)
df.group_by(pl.lit(True)).count()  # returns 3 (counts all rows)

The reason we cannot ignore nulls in group_by().count() is because there is no concept of a null row. Is a [0, 1, null] a null row? Is [null] a null row? (it's not the same as an empty row, which would be []). A group_by operation returns a frame, not a row, hence we cannot say how many non-null rows there are, because there is no concept of a null row. Does this make sense?

I agree that it is confusing. It is self-consistent, but it is nonetheless confusing.

from polars.

stevenlis avatar stevenlis commented on June 27, 2024

@ritchie46 @mcrumiller Thanks for the explanations. It seems like I missed the following statement in the doc.

This way of using the function is deprecated. Please use :func:len instead.

from polars.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.