cannot add `&std::string::String` to `std::string::String` when `use use polars::prelude::*;` about polars HOT 3 OPEN

Hi, the title name is not great for this issue. I was thinking "polars prelude interfer with Deref coercion" but since I am not 100% sure if it's really that, I put this more neutral title.

from polars.

I believe this is due to the way that polars uses the SmartString alias:

use smartstring::alias::String as SmartString;

and note that in SmartString, the definition is:

type String = SmartString<LazyCompact>;

Rust pros can answer this way better than I can, but I think that what's happening in polars is that we import the type definition, which redirects the use of String, and then aliases it again as a SmartString. This is inadvertent and I think we should probably explicitly make our own type definition that mimics smartstring::alias::String.

from polars.

The type of the variables in the example is not SmartString, it's still the Rust standard String (alloc::string::String).

from polars.