Giter VIP home page Giter VIP logo

Comments (7)

c-peters avatar c-peters commented on June 22, 2024 1

I can see a usecase though where you would want to perform operations first and then freeze the categories by casting from a Categorical to a Enum.

from polars.

markxwang avatar markxwang commented on June 22, 2024

It would be even nicer if the bins are correctly ordered when passed to enum

from polars.

c-peters avatar c-peters commented on June 22, 2024

Yes, I agree with @markxwang here. Enum is an orderded datatype, for cut I would much rather return an Enum directly than a categorical. See #13038.

from polars.

mcrumiller avatar mcrumiller commented on June 22, 2024

@c-peters I see you self-assigned. I have a working impl, if you haven't started already should I just submit a PR?

from polars.

c-peters avatar c-peters commented on June 22, 2024

After some more thought. We could allow this on Series (materialized data), but not on expressions. Categories are inside our Enum Datatype and are required for reasoning about the schema (correctness). If our Enum categories are dynamic then we can not reason up front if our query is correct which is an important property in our LogicalPlan.

from polars.

mcrumiller avatar mcrumiller commented on June 22, 2024

@c-peters I agree with you, and now I'm even hesitant to add this for Series, since the only reason is to workaround existing API issues where a categorical is returned instead of an enum.

Also, if we add an Enum as a return dtype to (for example) pl.cut, then we again are going to have a really hard time (read: impossible) propagating the schema in an expression context. What if someone uses pl.cut in a when/then and provides alternative values to what cut returns? Let's keep as categorical and reserve enums exclusively for static categoricals.

Do you agree here? I vote we just close and I'll cancel my PR.

from polars.

c-peters avatar c-peters commented on June 22, 2024

For pl.cut we do know the categories as they are the labels by the user or a derivative of the breaks parameter. So the schema would still be known after the operation.

But I agree, let's keep the Enums simple for now and exclusively use it for statics

from polars.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.