Comments (9)
I think we should deprecate/remove the truncate
offset
parameter. It is a separate operation and we shouldn't need to tell truncate
to perform additional operations at the beginning or the end when we can easily do them ourselves.
There must have been a reason for including it at some point. @MarcoGorelli do you know/recall?
from polars.
Yes, sorry. Fixed.
from polars.
@mcrumiller Do you mean deprecate the offset
parameter? This would also solve the documentation issue, but personally it makes sense to me to be able to offset windows when truncating in them.
from polars.
I think this predates my involvement in the project, but I'm also not sure why truncate
needs to have a offset
arg...you can easily do it yourself before or after truncating
from polars.
So this can be handled either purely on the python side by removing offset
from the documentation and not passing the argument onto the rust function. Or additionally by removing the functionality from the rust library. I am happy to handle all of the python and doc bits in an MR, but would need some help with the Rust side of things as I am less experienced there. I would be happy to give it a shot though.
from polars.
This would first need a deprecation warning, it can't be removed without notice :)
Fancy opening a pull request @TrevorWinstral ?
from polars.
Same for upsample, right?
from polars.
Will do, I will have to check how you guys handle depreciations elsewhere. Got an example on hand?
from polars.
There's plenty of examples in the codebase, there's a decorator for this, if you use that and fixup tests it should be good to go (sorry on my phone ATM)
from polars.
Related Issues (20)
- `read_ndjson()` and `read_parquet()` behave differently when the input is a list of files with different schemas HOT 1
- pl.from_numpy produces column with null dtype when input array is empty HOT 3
- equals lacks functionality that polars.testing.assert_frame_equal has HOT 6
- Polars drops pyarrow field-level metadata HOT 4
- Turn off CSE for new streaming engine
- Reading wide parquet is 25x slower with polars than pyarrow HOT 4
- In read_csv convert too long separator, quote_char, and/or eol_char to valid char HOT 2
- Optimize for simple math? HOT 3
- read_csv on gzipped csv much slower if n_rows specified
- CSV
- Some pl.Expr aggregations missing in the Aggregation section HOT 1
- Incorrect values calculated depending on the sequence of operations HOT 4
- from_jax
- Unexpected behaviour when calling list() on a slice of a series of dtype Object
- Make `new_streaming` feature available on Rust Polars HOT 1
- Parameters in `clip()` parse strings as column names, which is undocumented
- Add pl.Expr.min_by/max_by HOT 5
- `pl.Config.set_tbl_rows` doesn't work as expected HOT 1
- Support user defined aggregation functions/window functions as plugins HOT 1
- could not compile polars-arrow v0.42.0: the trait bound [buffer::immutable::Buffer]: Default is not satisfied HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from polars.