Comments (2)
Did some investigation into this issue and here are some findings:
- Default behavior is pretty good. Switching headings to paragraphs and back does not trigger the ACF and lose the id, even if other actions are done in between.
- Auto-save and manually saving also does not trigger the ACF, so an autosave will not lose the id.
- What does lose the id is toggling the source dialog, but in that case all of the elements are re-rendered anyway, so
customData
and expando data also do not work.
At this point, it seems that the way to allow data to persist through a toggle of source dialog or other such actions would be through storing heading data in a variable in the plugin itself. However, all of the more obvious cases for id persistence are already covered by default behavior. I think in these more complex cases, it would be little better than a guess as to whether persisting an id was actually the author's intention, at least until we get some user feedback
from ckeditor-plugin-autoid-headings.
Thanks for the writeup! Good summary of stuff we discussed.
Given that the major broken case seems to be source dialog (and I assume setData), we should just punt on this. Someone would have to de-header something and re-header it via the source dialog (or afterwards) for the id to go missing, which seems quite edgy.
from ckeditor-plugin-autoid-headings.
Related Issues (20)
- Automatically assign an id attribute to headings, if it is not set already HOT 2
- Viewer plugin implementation/rollout metaticket HOT 12
- use bootstrap popover for clipboard failure case HOT 12
- nodeList.forEach doesn't exist in IE11 and Firefox (until 50) HOT 4
- Replace blur handlers
- IE11 failure detection HOT 7
- Anchor click jump HOT 2
- Make the viewer test runner actually run in travis HOT 4
- Provide feedback when clipboardjs actually works
- Copy more formats
- Handle copy-paste cases HOT 5
- Look into Sauce for CI for IE HOT 1
- UX polish HOT 2
- Update the "Link Copied" text HOT 2
- Add support to pass in post-copy callback HOT 3
- Shorten the ids used for headings
- The selection change handler fails to detect a heading if the heading contains other tags
- Viewing: anchor-creating JavaScript HOT 1
- Better internal document linking HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ckeditor-plugin-autoid-headings.