Comments (5)
Possibly need to be firing the http://docs.ckeditor.com/#!/api/CKEDITOR.editor-event-updateSnapshot at the end of our dropdown ops
from ckeditor-plugin-structured-headings.
Better yet, just lockSnapshot & unlockSnapshot everywhere
from ckeditor-plugin-structured-headings.
The "classic" style combo fired snapshot simply saves a snapshot before and after you apply a style.
Our replacement for it doesn't do any such thing, which explains the random undo behaviour (if you accidentally do something else, it adds to undo)
from ckeditor-plugin-structured-headings.
The setting numbering style is a bit worse, something in between has a side effect of creating a snapshot, so we do need to actually lock it
from ckeditor-plugin-structured-headings.
This is surprisingly super annoying, managing snapshot side effects is horrible.
from ckeditor-plugin-structured-headings.
Related Issues (20)
- Null selection throws an error HOT 3
- Enable numbering styles menu in paragraphs
- String changes from usability testing
- Allow numbering menu to also apply to lists HOT 5
- Fix up the dropdown displayed value HOT 2
- Refactor the numstyles dropdown code HOT 1
- Fix the weird heading reset HOT 6
- Discover the existing heading preset on document load HOT 10
- Label fixes (again) HOT 3
- revert restart numbering behaviour HOT 1
- Fix the tab key HOT 3
- When range creating headings, only the first heading is set as autonumbered HOT 2
- Tripleclick range selection -> heading behaves strangely HOT 11
- Fix the default stylings to include MLA numbering
- Lack of a selection change when creating a new heading HOT 1
- Don't accidentally clear existing list classes HOT 2
- Revert list behaviour to previous HOT 3
- Switch to prettier
- Can't apply same style twice within nested list HOT 1
- Special case for no numbered headings HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ckeditor-plugin-structured-headings.