Giter VIP home page Giter VIP logo

Comments (5)

caffodian avatar caffodian commented on June 29, 2024

Possibly need to be firing the http://docs.ckeditor.com/#!/api/CKEDITOR.editor-event-updateSnapshot at the end of our dropdown ops

from ckeditor-plugin-structured-headings.

caffodian avatar caffodian commented on June 29, 2024

Better yet, just lockSnapshot & unlockSnapshot everywhere

from ckeditor-plugin-structured-headings.

caffodian avatar caffodian commented on June 29, 2024

The "classic" style combo fired snapshot simply saves a snapshot before and after you apply a style.

Our replacement for it doesn't do any such thing, which explains the random undo behaviour (if you accidentally do something else, it adds to undo)

from ckeditor-plugin-structured-headings.

caffodian avatar caffodian commented on June 29, 2024

The setting numbering style is a bit worse, something in between has a side effect of creating a snapshot, so we do need to actually lock it

from ckeditor-plugin-structured-headings.

caffodian avatar caffodian commented on June 29, 2024

This is surprisingly super annoying, managing snapshot side effects is horrible.

from ckeditor-plugin-structured-headings.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.