Assertion error in the "Extrinsic tab page" when user selects "timestamp" from the selection box labelled "from extrinsic section" about apps HOT 4 CLOSED

Aha, just dawned on me what the issue is - for type Timestamp we allocate a new Date object, here we try to work with a BN.

However, this one shouldn't be visible, it is an inherent extrinsic - the hidden flag is set, so the filtering is not checking for these to hide them -

https://github.com/polkadot-js/types/blob/master/packages/extrinsics/src/timestamp.js#L14

There is no filtering here -

https://github.com/polkadot-js/apps/blob/master/packages/ui-app/src/InputExtrinsic/options/method.js#L24

And some filtering here which doesn't lock out isHidden (not on the section, not on methods inside the section - methods should get filtered, when none left, section is also not displayed)

https://github.com/polkadot-js/apps/blob/master/packages/ui-app/src/InputExtrinsic/options/section.js#L17

Contrast this to storage, where actual filtering does take place -

https://github.com/polkadot-js/apps/blob/master/packages/ui-app/src/InputStorage/options/key.js#L23

from apps.

poc-1 chain I see... It could be that something broke in my last types (or even util) update - not sure what, will have to dig :(

EDIT: And the above is funky, since after the last noticiable upgrade, did do a couple of spot-checks, and that was exactly one of them.

from apps.

@jacogr In the files https://github.com/polkadot-js/apps/blob/master/packages/ui-app/src/InputStorage/options/key.tsx and https://github.com/polkadot-js/apps/blob/master/packages/ui-app/src/InputStorage/options/section.tsx, it doesn't contain type: 'private' | 'public' in the creationOptions function. Should we change it so it considers methods values that are contained within both the private and public keys (as it only seems to care about public ones at the moment), as can be seen performed in https://github.com/polkadot-js/apps/blob/master/packages/ui-app/src/InputExtrinsic/options/method.tsx?

Also, in https://github.com/polkadot-js/apps/blob/master/packages/ui-app/src/InputStorage/options/section.tsx, should the line return !section.isDeprecated && methods.length !== 0; instead be return !section.isDeprecated && !section.isHidden && methods.length !== 0;?

from apps.

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.

from apps.