Giter VIP home page Giter VIP logo

Comments (6)

dzen avatar dzen commented on June 18, 2024 1

Another issue : There are now default value in a few init function that where optionnal.
For instance, the delivery_mode is now 0 but this is an incorrect value
https://github.com/gmr/pamqp/blob/a35d0294ab5bc7ab335ff914d90bb19f05bd00e9/pamqp/commands.py#L2285 V.S.
https://github.com/gmr/pamqp/blob/master/pamqp/commands.py#L2339

from aioamqp.

RemiCardona avatar RemiCardona commented on June 18, 2024 1

Work done in #219 and pamqp 3.1.0 support added in 95cb160. @gmr thanks again for the heads up and the support

from aioamqp.

dzen avatar dzen commented on June 18, 2024

Thanks for the notification @gmr !

We should probably start by creating a PR thats will tests aioamqp with the latest pamqp version ?

from aioamqp.

gmr avatar gmr commented on June 18, 2024

Makes sense, but be aware there are structural changes to the library and I would not expect it to work as a drop-in replacement.

from aioamqp.

dzen avatar dzen commented on June 18, 2024

@gmr seems we have a regression on frame_parts which is now a private method.
gmr/pamqp#15

Any chance to convert it to a public method again ?

from aioamqp.

gmr avatar gmr commented on June 18, 2024

Sure, forgot about that.

from aioamqp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.