Giter VIP home page Giter VIP logo

Comments (28)

pomber avatar pomber commented on July 17, 2024 4

As far as I understand the changes from JHU CSSE, they have stopped publishing the recovered cases (at least for some countries). That's why you'll see nulls in the recovered property in the JSON.

I don't think using the last known number of recovered cases as a fallback instead of null is a good idea (for this repo, in your app do as you wish). I know nulls can break some apps that weren't expecting it, but showing false numbers without knowing is usually worse.

However, the updated data is available in the daily reports folder. We should switch the data source to these daily reports to stay accurate, but this is a massive change!

I'm not sure why they (JHU CSSE) are still posting some recovered numbers in the daily reports and not updating the time-series, but they still haven't done some of the changes they announced (adding testing_global.csv, adding the country ISO code). Also, they said "No recovered cases will be reported in the daily reports".

And if you ask me, they are doing an outstanding job collecting the data, but they are not handling the breaking changes very well.

from covid19.

nicolaschenet avatar nicolaschenet commented on July 17, 2024 2

A little bit more info: according to https://github.com/CSSEGISandData/COVID-19/blob/master/csse_covid_19_data/csse_covid_19_daily_reports/03-24-2020.csv, here are the numbers for France for example:

Confirmed Deaths Recovered Active
22304 1100 3281 17923

The figures for confirmed and deaths are a bit different than the ones located in

const FILENAME_CONFIRMED = "time_series_covid19_confirmed_global.csv";
const FILENAME_DEATHS = "time_series_covid19_deaths_global.csv";

which I find a tad weird though...

from covid19.

ahmadsyamim avatar ahmadsyamim commented on July 17, 2024
{
      "date": "2020-3-24",
      "confirmed": 123,
      "deaths": 5
    }

from covid19.

nicolaschenet avatar nicolaschenet commented on July 17, 2024

Coming from CSSEGISandData/COVID-19.

It’s due to the deprecations on the data files in the time series folder. They provided new files for deaths and confirmed cases but nothing for recovered.

However, the updated data is available in the daily reports folder. We should switch the data source to these daily reports to stay accurate, but this is a massive change!

from covid19.

GunjanChugh avatar GunjanChugh commented on July 17, 2024

Are you planning to do the required changes? If yes, what is the estimated time?

from covid19.

nicolaschenet avatar nicolaschenet commented on July 17, 2024

Let's @pomber respond to this one :)

from covid19.

chandan-reddy-k avatar chandan-reddy-k commented on July 17, 2024

Yes, @pomber my charts are also broken due to this. Can you please look into this? 😅

from covid19.

RemDelaporteMathurin avatar RemDelaporteMathurin commented on July 17, 2024

Mine are as well ! 😃

from covid19.

bauefi avatar bauefi commented on July 17, 2024

Same here 😃

from covid19.

agaktr avatar agaktr commented on July 17, 2024

yeah, made a fallback in my code but please inform us when its fixed! you can as a fallback just put the previous day recovered in the variable so we do not have a problem!!

from covid19.

GunjanChugh avatar GunjanChugh commented on July 17, 2024

@agaktr I adopted for same fallback mechanism. The code application will not break by this but the data will be outdated.

from covid19.

chandan-reddy-k avatar chandan-reddy-k commented on July 17, 2024

@agaktr I did the same thing but if the country has more recovered cases today then the previous day, it won't be updated and will lead to false calculations.

from covid19.

pcmnac avatar pcmnac commented on July 17, 2024

did the same as @agaktr and the others.

reference for those using js
https://github.com/dsplay/covid19-ds-panel/blob/master/src/util/series.js#L40

from covid19.

RemDelaporteMathurin avatar RemDelaporteMathurin commented on July 17, 2024

Hi @pomber, can this issue be solved by any mean ?

from covid19.

RemDelaporteMathurin avatar RemDelaporteMathurin commented on July 17, 2024

I agree that the "last known number" isn't a good solution at all and breaks the calculations. So if I understood correctly, we shall wait for changes from JHU CSSE ?

from covid19.

pomber avatar pomber commented on July 17, 2024

we shall wait for changes from JHU CSSE ?

Yes. Meanwhile, make sure your apps support null recovered cases.

You can also read the whole thread or open issues for clarifications on the JHU repo.

from covid19.

chandan-reddy-k avatar chandan-reddy-k commented on July 17, 2024

@pomber is there a way to get active cases from the source ?

from covid19.

ExpDev07 avatar ExpDev07 commented on July 17, 2024

@chandan-reddy-k confirmed - recovered - deaths should give active, but now that recoveries are not available, not really :/.

from covid19.

chandan-reddy-k avatar chandan-reddy-k commented on July 17, 2024

@ExpDev07 Yup that’s how I was doing but what I meant is CSSE is giving out daily reports and it has both active and recovered counts. So is there a way we can parse that file and get the values ?

from covid19.

ExpDev07 avatar ExpDev07 commented on July 17, 2024

@chandan-reddy-k youd have to build a scraper that takes the daily reports and puts them in a queryable database. It’s a heavy task and not something you wanna do when just starting the app. This is why the timeline files were so great, you just make 3 HTTP requests, parse the CSV and you’re done. No scraping needed, it’s something you can do on the run (given you cache the results).

from covid19.

Mikeaat avatar Mikeaat commented on July 17, 2024

JHU CSSE added a new File for recovered in the time_series.
Now these 3 are available:
time_series_covid19_confirmed_global.csv
time_series_covid19_deaths_global.csv
time_series_covid19_recovered_global.csv

from covid19.

ExpDev07 avatar ExpDev07 commented on July 17, 2024

There’s still some issues with the recovery file. I have no idea what they’re even doing at this point. Contradicting announcements, format changes every day almost...

from covid19.

awaisahmed119 avatar awaisahmed119 commented on July 17, 2024

All recovered data is null now.

from covid19.

nicolaschenet avatar nicolaschenet commented on July 17, 2024

@awaisahmed119 A fix is on the go

from covid19.

pomber avatar pomber commented on July 17, 2024

All recovered data is null now.

See #74

Should be fixed now.

from covid19.

azrindipu avatar azrindipu commented on July 17, 2024

API gives null value in "recovered" field at date "2020-3-25" for all countries.

from covid19.

pomber avatar pomber commented on July 17, 2024

API gives null value in "recovered" field at date "2020-3-25" for all countries.

Yep, that's because there isn't data reported for that day in the source csv.

from covid19.

chandan-reddy-k avatar chandan-reddy-k commented on July 17, 2024

@pomber @ExpDev07 looks like the source has reported recovered cases today, including the previous days.

from covid19.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.