Giter VIP home page Giter VIP logo

Comments (7)

aeantipov avatar aeantipov commented on July 18, 2024

I remember this issue appearing in the context of ALPSCore. The idea of sharing dependencies is to enforce the correct linking (like, say when multiple modules on clusters are present). It should 'always work' in a sense that as long as
(1) pomerol is compiled correctly and tests pass
(2) the export is correct,
the dependent library should just get it. However in this case it seems that INTERFACE_LINK_LIBRARIES are wrong.

from pomerol.

aeantipov avatar aeantipov commented on July 18, 2024

In particular, I remember now, without this one ends up often linked to a system boost. In a sense one has to run cmake with the arguments like BOOST_ROOT the same as those used for compilation. So the goal of providing libraries is to avoid that.

from pomerol.

krivenko avatar krivenko commented on July 18, 2024

Looks like our own code has little to do with this issue. On macOS, find_package(Boost) sets Boost_INCLUDE_DIRS and Boost_LIBRARIES to the following values respectively,

-- Boost includes: /usr/local/include
-- Boost libs: Boost::mpi;Boost::serialization

https://travis-ci.org/github/aeantipov/pomerol/jobs/666864157#L740

from pomerol.

aeantipov avatar aeantipov commented on July 18, 2024

There's a thread for some package having a similar issue.
We should restrict the maximum version of boost because cmake bindings are always lagging behind.
exercism/cpp#217

from pomerol.

krivenko avatar krivenko commented on July 18, 2024

My impression is that it's totally legal for FindBoost.cmake to put Boost target names into Boost_LIBRARIES. I just don't understand why its behavior is inconsistent between platforms (CMake versions? Boost versions?)

from pomerol.

krivenko avatar krivenko commented on July 18, 2024

Pomerol 2.0 does not depend on Boost.MPI and Boost.Serialization anymore.
One should try to build the updated pomerol2triqs on macOS and see if this issue is actually gone.

from pomerol.

krivenko avatar krivenko commented on July 18, 2024

I am closing this issue since pomerol2triqs is sucessfully built by a macOS 11 GitHub Actions runner now.

https://github.com/pomerol-ed/pomerol2triqs/actions/runs/3619457035/jobs/6100523644

from pomerol.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.