Comments (4)
Hey, thanks for the report. Is this reproducible on your end. I followed the instructions and works as expected. Please provide more detail on how often this happens, what you did before etc.
from draw.
Easily reproducible even with clean install. I'm able to reproduce with these steps:
1. git clone https://github.com/pomle/draw.git
2. cd draw/
, npm update
, npm start
3. 2 incognito chrome windows with ctrl + shift + N
Window 1: started to host with default random name 'LEPA'
Window 2: Successfully, joined the room named 'LEPA'
4. Refreshed both incognito windows.
Window 1: started to host with a lobby name 'test' Says:
Welcome to the Lobby
Join the game at
test
Window 2: Cannot join the room named 'test'. Says:
Could not connect to peer TEST
Versions
Chrome: 63.0.3239.132 (64 bit)
npm: 5.6.0
node: 8.9.4
from draw.
Found it! the problem is this:
When hosting a lobby, the name has to be uppercase. From joining side it doesn't matter.
Forcing uppercase can be the solution.
from draw.
@mert574 great!
I remember this. I uppercased the input when I created random session words.
I think the solution we should try, is normalize it to uppercase when it is sent to the server for peering, but keep it as entered in the client. That way the room name when given can be displayed with picked case, while still be case insensitive when entered.
from draw.
Related Issues (6)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from draw.