NullPointerException when creating new `FileSystem` from URI without username-component about smb-nio HOT 6 CLOSED

Haha well talking about peculiarities of the Java API ... :-)

So I understand the issue is fixed and I thus close it. Should you encounter more problems, just open a new one.

from smb-nio.

For completeness sake, I should mention I'm using this on JDK Eclipse Temurin 17.0.4.1
Perhaps the return-value of getAuthority changed from empty-string to null somewhere?

from smb-nio.

Hey! Happy to hear, that this library is proving useful.

I agree with your assessment that there should be a null-check. According to the official JavaDoc URI.getAuthority() can indeed return null.

I have just committed a fix and I'm releasing a new version.

from smb-nio.

Talk about instant turn-around!

Version 0.12.0 no longer throws the NPE. Fixed!

I'm still figuring out how to actually use the API correctly, to list the contents of a directory, but that's a different topic alltogether.

from smb-nio.

Side note: my API problems were because my IP-handling was accidentally adding an additional forward-slash inside the URL.
TL;DR use InetAddress.getHostAddress(), never InetAddress.toString() 😦

instead of smb://1.2.3.4/root/ I thus got smb:///1.2.3.4/root/, which breaks in all kinds of interesting ways 😆

from smb-nio.

It looks like the fix for this caused a regression since the constructed authority string is effectively duplicated.
I have provided #27, assuming this fixes that regression.

from smb-nio.