Giter VIP home page Giter VIP logo

Comments (11)

KagamiChan avatar KagamiChan commented on July 3, 2024

Land base raid happens randomly and does not let any ship drop, it is better to record in another collection

On enemyShips you're right, but it does not affect data collecting because we changed the model
https://github.com/poooi/poi-server/blob/master/models/report/drop-ship.es#L14

from plugin-report.

KagamiChan avatar KagamiChan commented on July 3, 2024

Anyway the enemyShips1 and enemyShips2 initialization will be added

But what could air raid data collection serve for?

from plugin-report.

gakada avatar gakada commented on July 3, 2024

IIRC 長距離空襲戦 (ld_airbattle) also don't drop ships? So it's for enemy patterns only in this case. Like

from plugin-report.

KagamiChan avatar KagamiChan commented on July 3, 2024

Using the same data collection will result in double drop reports in a single battle on certain cells and the drop rate on these cells will never be accurate

from plugin-report.

gakada avatar gakada commented on July 3, 2024

Yeah, if it's not filtered by an extra flag I mentioned, OR, if without changing the schema, can set cellId to a special value, like -1 or -cellId (that is, negative cellId), for the "AB node".
u

from plugin-report.

gakada avatar gakada commented on July 3, 2024

@KagamiChan would it be ok for another viewer to implement this? I.e., to report api_destruction_battle enemy compositions in drop_ship collection with a special negative cellId value. I think poi server won't filter those reports, so they will end up in the dump, available for wikis/etc.

from plugin-report.

KagamiChan avatar KagamiChan commented on July 3, 2024

I still prefer creating a separate data collection for this, anyway staff at kcwiki should be informed and involved @Gizeta

from plugin-report.

Gizeta avatar Gizeta commented on July 3, 2024

I don't think it's a good idea to save land base air raid compositions in the DropShipRecord database table, although it doesn't affect the drop statistics. However, you can just post those negative cellId values but filter them on poi-server to save in a new table, such as

record = data.cellId < 0 ? new NewTableForLandBaseAirRaid(data) : new DropShipRecord(data)
record.save()

But, I think it's tricky. Why not create some new API on poi-server for the land base air raid?

from plugin-report.

gakada avatar gakada commented on July 3, 2024

Well, my argument was that there is already non-drop and composition-only data from corresponding (game) endpoints in DropShipRecord, so this is just another one of those endpoints. Then, it is probably easier to utilize existing code in drop-ship.es, the change is simple if it is the same table, so I made #13.

If it must be a different table, then yeah, extra class/schema/endpoint here and in poi-server (+ available dump, like dropshiprecords.gz).

from plugin-report.

KagamiChan avatar KagamiChan commented on July 3, 2024

poi-server also accepts pull requests for creating new schema and endpoints, you may consider add a new report type, say, BaseAirRaidRecord, for both plugin-report and poi-server

and I'll add the dumping once the data set is available

P.S. Here's some instructions on how to locally test reporter and poi server: https://github.com/poooi/plugin-report/wiki

from plugin-report.

gakada avatar gakada commented on July 3, 2024

Looking at https://github.com/andanteyk/ElectronicObserver/blob/develop/ElectronicObserver/Other/Information/apilist.txt#L1517 there is more things in api_req_map/next that are kinda required for full info, for example

  • node types, api_color_no/api_event_id/api_event_kind, currently only api_event_id is used for isBoss
  • node events: api_itemget, api_happening
  • various node rewards
  • routing, that is current fleet (ships, stats, equipment) and route taken
  • and then api_destruction_battle

from plugin-report.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.