Giter VIP home page Giter VIP logo

Comments (2)

AndreMikulec avatar AndreMikulec commented on August 10, 2024

Dave Cramer,

I read the Travis file travis.yml, and based on what I read, I made a Github Actions file .github/workflows/build.yml. Using the new build.yml file and Github Actions, I successfully built and tested plr with versions of PostgreSQL from 9.5 through 13.

In the file ".github/workflows/build.yml" only some minor changes were done.

  1. Changed
    setfacl -Rm u:postgres:rwx,d:u:travis:rwx $HOME
    to
    sudo setfacl -Rm u:postgres:rwx,d:u:runner:rwx /home/runner

In Travis, the build-test runs under "travis".
In Github Actions, the build-test runs under "runner".

In Travis, $HOME may be volatile.
In Github Actions, $HOME is static at /home/runner.

In Travis, to use "setfacl", elevated privileges are not needed.
In Github Actions, to use "setfacl", elevated priviledges are needed.

  1. Changed
sudo make install

to

sudo USE_PGXS=1 make install

In Travis, the first former case works.
In Github Actions, the former case does not work; I received errors.
To make the build-test work, I used "USE_PGXS=1".

Changed
single-line commands
into
multi-line commands

This was not required. This minimized the number of processes. It looks cleaner.

Here is the commit
AndreMikulec@9da5156
in branch
https://github.com/AndreMikulec/plr/tree/83_Convert_Linux_Tests_on_Travis_to_Tests_on_Github_Actions

Here is the build result.
https://github.com/AndreMikulec/plr/actions/runs/669678071

Here is the PostgreSQL 13 run result.
https://github.com/AndreMikulec/plr/runs/2153212316?check_suite_focus=true

What do you think?

Do you think that build-tests, using Github Actions, may become a permanent part of "postgres-plr?

from plr.

davecramer avatar davecramer commented on August 10, 2024

Well the simplest solution would be to move to travis-ci.com, but I prefer github actions. So I'd be up for this. Can you create a PR for it

from plr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.